chore: clean up eslint-disable lines (#4735)

jsjoeio · web-flow · commit dea329705ac1 · 2022-10-24T21:55:44.000-03:00
* chore: drop eslint-disable rule

* refactor: add types for makeMockApiError
diff --git a/site/src/components/WorkspaceScheduleForm/WorkspaceScheduleForm.tsx b/site/src/components/WorkspaceScheduleForm/WorkspaceScheduleForm.tsx
@@ -99,7 +99,6 @@ export interface WorkspaceScheduleFormValues {
   ttl: number
 }
 
-// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
 export const validationSchema = Yup.object({
   sunday: Yup.boolean(),
   monday: Yup.boolean().test(
diff --git a/site/src/testHelpers/entities.ts b/site/src/testHelpers/entities.ts
@@ -814,15 +814,29 @@ export const MockCancellationMessage = {
   message: "Job successfully canceled",
 }
 
-// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
-export const makeMockApiError = ({
-  message,
-  detail,
-  validations,
-}: {
+type MockAPIInput = {
   message?: string
   detail?: string
   validations?: FieldError[]
+}
+
+type MockAPIOutput = {
+  response: {
+    data: {
+      message: string
+      detail: string | undefined
+      validations: FieldError[] | undefined
+    }
+  }
+  isAxiosError: boolean
+}
+
+type MakeMockApiErrorFunction = (input: MockAPIInput) => MockAPIOutput
+
+export const makeMockApiError: MakeMockApiErrorFunction = ({
+  message,
+  detail,
+  validations,
 }) => ({
   response: {
     data: {

Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,6 @@ export interface WorkspaceScheduleFormValues {`
`99`	`99`	`ttl: number`
`100`	`100`	`}`
`101`	`101`
`102`		`-// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types`
`103`	`102`	`export const validationSchema = Yup.object({`
`104`	`103`	`sunday: Yup.boolean(),`
`105`	`104`	`monday: Yup.boolean().test(`