remove filepath usage on windows to control output

mafredri · mafredri · commit df26e5272f85 · 2023-12-19T13:39:50.000Z
diff --git a/cli/open.go b/cli/open.go
@@ -6,7 +6,6 @@ import (
 	"net/url"
 	"path"
 	"path/filepath"
-	"runtime"
 	"strings"
 
 	"github.com/skratchdot/open-golang/open"
@@ -236,13 +235,8 @@ func waitForAgentCond(ctx context.Context, client *codersdk.Client, workspace co
 	return workspace, workspaceAgent, xerrors.New("watch workspace: unexpected closed channel")
 }
 
-// isWindowsAbsPath checks if the path is an absolute path on Windows. On Unix
-// systems the check is very simplistic and does not cover edge cases.
+// isWindowsAbsPath checks if the path is an absolute path on Windows.
 func isWindowsAbsPath(p string) bool {
-	if runtime.GOOS == "windows" {
-		return filepath.IsAbs(p)
-	}
-
 	// Remove the drive letter, if present.
 	if len(p) >= 2 && p[1] == ':' {
 		p = p[2:]
@@ -259,13 +253,8 @@ func isWindowsAbsPath(p string) bool {
 }
 
 // windowsJoinPath joins the elements into a path, using Windows path separator
-// and converting forward slashes to backslashes. On Unix systems a very
-// simplistic join operator is used.
+// and converting forward slashes to backslashes.
 func windowsJoinPath(elem ...string) string {
-	if runtime.GOOS == "windows" {
-		return filepath.Join(elem...)
-	}
-
 	var s string
 	for _, e := range elem {
 		e = strings.ReplaceAll(e, "/", "\\")
