Fix build number to be 1 indexed

Emyrk · Emyrk · commit e086e5141de3 · 2023-02-02T11:07:58.000-06:00
diff --git a/coderd/authzquery/methods_test.go b/coderd/authzquery/methods_test.go
@@ -119,6 +119,10 @@ MethodLoop:
 			// TODO: Should we assert the object returned is the correct one?
 			for _, r := range resp {
 				if r.Type().Implements(reflect.TypeOf((*error)(nil)).Elem()) {
+					if r.IsNil() {
+						// no error!
+						break
+					}
 					err, ok := r.Interface().(error)
 					if !ok {
 						t.Fatal("error is not an error?!")
diff --git a/coderd/authzquery/workspace_test.go b/coderd/authzquery/workspace_test.go
@@ -35,6 +35,7 @@ func (s *MethodTestSuite) TestWorkspace() {
 	s.Run("GetLatestWorkspaceBuildsByWorkspaceIDs", func() {
 		s.RunMethodTest(func(t *testing.T, db database.Store) MethodCase {
 			ws := dbgen.Workspace(t, db, database.Workspace{})
+			_ = dbgen.WorkspaceBuild(t, db, database.WorkspaceBuild{WorkspaceID: ws.ID})
 			return methodCase(
 				inputs([]uuid.UUID{ws.ID}),
 				asserts(ws, rbac.ActionRead))
diff --git a/coderd/database/dbgen/generator.go b/coderd/database/dbgen/generator.go
@@ -130,7 +130,7 @@ func WorkspaceBuild(t *testing.T, db database.Store, orig database.WorkspaceBuil
 		UpdatedAt:         takeFirst(orig.UpdatedAt, time.Now()),
 		WorkspaceID:       takeFirst(orig.WorkspaceID, uuid.New()),
 		TemplateVersionID: takeFirst(orig.TemplateVersionID, uuid.New()),
-		BuildNumber:       takeFirst(orig.BuildNumber, 0),
+		BuildNumber:       takeFirst(orig.BuildNumber, 1),
 		Transition:        takeFirst(orig.Transition, database.WorkspaceTransitionStart),
 		InitiatorID:       takeFirst(orig.InitiatorID, uuid.New()),
 		JobID:             takeFirst(orig.JobID, uuid.New()),
