Fix hanging tests

code-asher · code-asher · commit e0b78cc246c8 · 2023-10-12T04:06:08.000-08:00
I am not really sure what ws.connected is doing but it seems to somehow
block updates.  Basically, the useEffect creating the terminal never
updates when the config loads, so the web socket is never created, and
the test hangs forever.

Before I think it worked because the web socket did not block on the
terminal being created, but we need the terminal first so we can get the
size and spawn with the right height/width to avoid a screen bug.
diff --git a/site/src/pages/TerminalPage/TerminalPage.test.tsx b/site/src/pages/TerminalPage/TerminalPage.test.tsx
@@ -127,7 +127,7 @@ describe("TerminalPage", () => {
     const { container } = await renderTerminal();
 
     // Then
-    await ws.connected;
+    await ws.nextMessage;
     ws.send(text);
     await expectTerminalText(container, text);
     ws.close();
@@ -143,7 +143,6 @@ describe("TerminalPage", () => {
     await renderTerminal();
 
     // Then
-    await ws.connected;
     const msg = await ws.nextMessage;
     const req = JSON.parse(new TextDecoder().decode(msg as Uint8Array));
     expect(req.height).toBeGreaterThan(0);
@@ -164,7 +163,7 @@ describe("TerminalPage", () => {
     );
 
     // Then
-    await ws.connected;
+    await ws.nextMessage;
     ws.send(text);
     await expectTerminalText(container, text);
     ws.close();
