fix: case insensitve agent ssh session env var (#9675)

Emyrk · web-flow · commit e0e6d7c9a6b2 · 2023-09-13T14:18:00.000-05:00
diff --git a/agent/agentssh/agentssh.go b/agent/agentssh/agentssh.go
@@ -254,11 +254,13 @@ func (s *Server) sessionStart(session ssh.Session, extraEnv []string) (retErr er
 		magicType = strings.TrimPrefix(kv, MagicSessionTypeEnvironmentVariable+"=")
 		env = append(env[:index], env[index+1:]...)
 	}
-	switch magicType {
-	case MagicSessionTypeVSCode:
+
+	// Always force lowercase checking to be case-insensitive.
+	switch strings.ToLower(magicType) {
+	case strings.ToLower(MagicSessionTypeVSCode):
 		s.connCountVSCode.Add(1)
 		defer s.connCountVSCode.Add(-1)
-	case MagicSessionTypeJetBrains:
+	case strings.ToLower(MagicSessionTypeJetBrains):
 		s.connCountJetBrains.Add(1)
 		defer s.connCountJetBrains.Add(-1)
 	case "":
diff --git a/agent/agentssh/metrics.go b/agent/agentssh/metrics.go
@@ -1,6 +1,8 @@
 package agentssh
 
 import (
+	"strings"
+
 	"github.com/prometheus/client_golang/prometheus"
 )
 
@@ -78,5 +80,6 @@ func magicTypeMetricLabel(magicType string) string {
 	default:
 		magicType = "unknown"
 	}
-	return magicType
+	// Always be case insensitive
+	return strings.ToLower(magicType)
 }

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,8 @@`
`1`	`1`	`package agentssh`
`2`	`2`
`3`	`3`	`import (`
	`4`	`+ "strings"`
	`5`	`+`
`4`	`6`	`"github.com/prometheus/client_golang/prometheus"`
`5`	`7`	`)`
`6`	`8`
`@@ -78,5 +80,6 @@ func magicTypeMetricLabel(magicType string) string {`
`78`	`80`	`default:`
`79`	`81`	`magicType = "unknown"`
`80`	`82`	`}`
`81`		`- return magicType`
	`83`	`+ // Always be case insensitive`
	`84`	`+ return strings.ToLower(magicType)`
`82`	`85`	`}`