fix: Multiple builds using the incorrect agent token (#983)

kylecarbs · web-flow · commit e3458277dff4 · 2022-04-12T20:11:57.000Z
This was an issue with our in-memory database that caused
newer builds to return an outdated agent, which would then
be rejected.

A test case has been added to ensure this can't happen again!
diff --git a/coderd/database/databasefake/databasefake.go b/coderd/database/databasefake/databasefake.go
@@ -626,7 +626,9 @@ func (q *fakeQuerier) GetWorkspaceAgentByAuthToken(_ context.Context, authToken
 	q.mutex.RLock()
 	defer q.mutex.RUnlock()
 
-	for _, agent := range q.provisionerJobAgent {
+	// The schema sorts this by created at, so we iterate the array backwards.
+	for i := len(q.provisionerJobAgent) - 1; i >= 0; i-- {
+		agent := q.provisionerJobAgent[i]
 		if agent.AuthToken.String() == authToken.String() {
 			return agent, nil
 		}
