fix(coderd): prevent nil err deref

johnstcn · johnstcn · commit e34a37aeb282 · 2024-03-08T16:00:11.000Z
diff --git a/coderd/files.go b/coderd/files.go
@@ -175,7 +175,7 @@ func (api *API) fileByID(rw http.ResponseWriter, r *http.Request) {
 		if file.Mimetype != codersdk.ContentTypeTar {
 			httpapi.Write(ctx, rw, http.StatusBadRequest, codersdk.Response{
 				Message: "Only .tar files can be converted to .zip format",
-				Detail:  err.Error(),
+				Detail:  "",
 			})
 			return
 		}
@@ -192,7 +192,7 @@ func (api *API) fileByID(rw http.ResponseWriter, r *http.Request) {
 	default:
 		httpapi.Write(ctx, rw, http.StatusBadRequest, codersdk.Response{
 			Message: "Unsupported conversion format.",
-			Detail:  err.Error(),
+			Detail:  "",
 		})
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -175,7 +175,7 @@ func (api API) fileByID(rw http.ResponseWriter, r http.Request) {`
`175`	`175`	`if file.Mimetype != codersdk.ContentTypeTar {`
`176`	`176`	`httpapi.Write(ctx, rw, http.StatusBadRequest, codersdk.Response{`
`177`	`177`	`Message: "Only .tar files can be converted to .zip format",`
`178`		`- Detail: err.Error(),`
	`178`	`+ Detail: "",`
`179`	`179`	`})`
`180`	`180`	`return`
`181`	`181`	`}`
`@@ -192,7 +192,7 @@ func (api API) fileByID(rw http.ResponseWriter, r http.Request) {`
`192`	`192`	`default:`
`193`	`193`	`httpapi.Write(ctx, rw, http.StatusBadRequest, codersdk.Response{`
`194`	`194`	`Message: "Unsupported conversion format.",`
`195`		`- Detail: err.Error(),`
	`195`	`+ Detail: "",`
`196`	`196`	`})`
`197`	`197`	`}`
`198`	`198`	`}`