chore: merge codeql checks to run in parallel (#5907)

kylecarbs · web-flow · commit e49f41652f2a · 2023-01-29T15:28:22.000-06:00
* chore: merge codeql checks to run in parallel This reduces a check and should maintain ~the same CI time. * fix: close reconnecting pty conn when exiting agent Fixes https://github.com/coder/coder/actions/runs/4038282899/jobs/6942170850 * Fix closing when agent fails * Fix conpty * Fix contrib * Skip runner tests for being flakes * Fix gpg key test * Fix golden files * Fix comments * Fix closed * Fix capitalized title * Add a timeout when checking for dead links
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -96,6 +96,7 @@ jobs:
       - if: github.ref == 'refs/heads/main' && !github.event.pull_request.head.repo.fork
         uses: gaurav-nelson/github-action-markdown-link-check@v1
         name: Check for dead links (main)
+        timeout-minutes: 1
         with:
           use-quiet-mode: yes
           use-verbose-mode: yes
@@ -104,6 +105,7 @@ jobs:
       - if: github.ref != 'refs/heads/main' || github.event.pull_request.head.repo.fork
         uses: gaurav-nelson/github-action-markdown-link-check@v1
         name: Check for dead links (pull request)
+        timeout-minutes: 1
         with:
           use-quiet-mode: yes
           use-verbose-mode: yes
diff --git a/.github/workflows/contrib.yaml b/.github/workflows/contrib.yaml
@@ -59,7 +59,6 @@ jobs:
           requireScope: false
 
   release-labels:
-    name: Release labels
     runs-on: ubuntu-latest
     # Depend on lint so that title is Conventional Commits-compatible.
     needs: [title]
diff --git a/.github/workflows/security.yaml b/.github/workflows/security.yaml
@@ -27,49 +27,37 @@ concurrency:
 jobs:
   codeql:
     runs-on: ${{ github.repository_owner == 'coder' && 'ubuntu-latest-16-cores' || 'ubuntu-latest' }}
-    strategy:
-      fail-fast: false
-      matrix:
-        language: ["go", "javascript"]
-
     steps:
-      - name: Checkout repository
-        uses: actions/checkout@v3
+      - uses: actions/checkout@v3
 
       - name: Initialize CodeQL
         uses: github/codeql-action/init@v2
         with:
-          languages: ${{ matrix.language }}
+          languages: go, javascript
 
       - name: Setup Go
-        if: matrix.language == 'go'
         uses: actions/setup-go@v3
         with:
           go-version: "~1.19"
 
       - name: Go Cache Paths
-        if: matrix.language == 'go'
         id: go-cache-paths
         run: |
           echo "GOMODCACHE=$(go env GOMODCACHE)" >> $GITHUB_OUTPUT
 
       - name: Go Mod Cache
-        if: matrix.language == 'go'
         uses: actions/cache@v3
         with:
           path: ${{ steps.go-cache-paths.outputs.GOMODCACHE }}
           key: ${{ runner.os }}-release-go-mod-${{ hashFiles('**/go.sum') }}
 
       # Workaround to prevent CodeQL from building the dashboard.
       - name: Remove Makefile
-        if: matrix.language == 'go'
         run: |
           rm Makefile
 
       - name: Perform CodeQL Analysis
         uses: github/codeql-action/analyze@v2
-        with:
-          category: "/language:${{matrix.language}}"
 
   trivy:
     runs-on: ${{ github.repository_owner == 'coder' && 'ubuntu-latest-16-cores' || 'ubuntu-latest' }}
