fix generic internal server error

mafredri · mafredri · commit e5b96d4e833f · 2023-07-21T08:47:44.000Z
diff --git a/coderd/insights.go b/coderd/insights.go
@@ -97,15 +97,21 @@ func (api *API) insightsUserLatency(rw http.ResponseWriter, r *http.Request) {
 		TemplateIDs: templateIDs,
 	})
 	if err != nil {
-		httpapi.InternalServerError(rw, err)
+		httpapi.Write(ctx, rw, http.StatusInternalServerError, codersdk.Response{
+			Message: "Internal error fetching user latency.",
+			Detail:  err.Error(),
+		})
 		return
 	}
 
 	// Fetch all users so that we can still include users that have no
 	// latency data.
 	users, err := api.Database.GetUsers(ctx, database.GetUsersParams{})
 	if err != nil {
-		httpapi.InternalServerError(rw, err)
+		httpapi.Write(ctx, rw, http.StatusInternalServerError, codersdk.Response{
+			Message: "Internal error fetching users.",
+			Detail:  err.Error(),
+		})
 		return
 	}
 
@@ -238,7 +244,10 @@ func (api *API) insightsTemplates(rw http.ResponseWriter, r *http.Request) {
 		return nil
 	}, nil)
 	if err != nil {
-		httpapi.InternalServerError(rw, err)
+		httpapi.Write(ctx, rw, http.StatusInternalServerError, codersdk.Response{
+			Message: "Internal error fetching template insights.",
+			Detail:  err.Error(),
+		})
 		return
 	}
 
