fix some tests

johnstcn · johnstcn · commit e600b7d5913e · 2025-03-26T16:36:59.000Z
diff --git a/coderd/database/dbauthz/dbauthz_test.go b/coderd/database/dbauthz/dbauthz_test.go
@@ -4532,7 +4532,14 @@ func (s *MethodTestSuite) TestSystemFunctions() {
 		check.Args(true).Asserts(rbac.ResourceDeploymentConfig, policy.ActionUpdate)
 	}))
 	s.Run("GetNotificationVAPIDKeys", s.Subtest(func(db database.Store, check *expects) {
-		check.Args().Asserts(rbac.ResourceDeploymentConfig, policy.ActionRead).Errors(sql.ErrNoRows)
+		require.NoError(s.T(), db.UpsertNotificationVAPIDKeys(context.Background(), database.UpsertNotificationVAPIDKeysParams{
+			VapidPublicKey:  "test",
+			VapidPrivateKey: "test",
+		}))
+		check.Args().Asserts(rbac.ResourceDeploymentConfig, policy.ActionRead).Returns(database.GetNotificationVAPIDKeysRow{
+			VapidPublicKey:  "test",
+			VapidPrivateKey: "test",
+		})
 	}))
 	s.Run("UpsertNotificationVAPIDKeys", s.Subtest(func(db database.Store, check *expects) {
 		check.Args(database.UpsertNotificationVAPIDKeysParams{
diff --git a/coderd/database/migrations/testdata/fixtures/000311_push_notifications.up.sql b/coderd/database/migrations/testdata/fixtures/000311_push_notifications.up.sql
@@ -0,0 +1,2 @@
+-- VAPID keys lited from coderd/notifications_test.go.
+INSERT INTO notification_push_subscriptions (id, user_id, created_at, endpoint, endpoint_p256dh_key, endpoint_auth_key) VALUES (gen_random_uuid(), (SELECT id FROM users LIMIT 1), NOW(), 'https://example.com', 'BNNL5ZaTfK81qhXOx23+wewhigUeFb632jN6LvRWCFH1ubQr77FE/9qV1FuojuRmHP42zmf34rXgW80OvUVDgTk=', 'zqbxT6JKstKSY9JKibZLSQ==');

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+-- VAPID keys lited from coderd/notifications_test.go.`
	`2`	`+INSERT INTO notification_push_subscriptions (id, user_id, created_at, endpoint, endpoint_p256dh_key, endpoint_auth_key) VALUES (gen_random_uuid(), (SELECT id FROM users LIMIT 1), NOW(), 'https://example.com', 'BNNL5ZaTfK81qhXOx23+wewhigUeFb632jN6LvRWCFH1ubQr77FE/9qV1FuojuRmHP42zmf34rXgW80OvUVDgTk=', 'zqbxT6JKstKSY9JKibZLSQ==');`