fix: update isNotificationTextPrefixed

jsjoeio · jsjoeio · commit e6a5499cef22 · 2022-09-15T17:36:47.000Z
This removes an eslint-disable rule and adds two new tests to ensure
isNotificationTextPrefixed is working as expected.
diff --git a/site/src/components/GlobalSnackbar/utils.test.ts b/site/src/components/GlobalSnackbar/utils.test.ts
@@ -4,6 +4,7 @@ import {
   isNotificationTextPrefixed,
   MsgType,
   NotificationMsg,
+  NotificationTextPrefixed,
   SnackbarEventType,
 } from "./utils"
 
@@ -17,6 +18,29 @@ describe("Snackbar", () => {
       // When
       const isTextPrefixed = isNotificationTextPrefixed(msg)
 
+      // Then
+      expect(isTextPrefixed).toBe(false)
+    })
+    it("returns true if prefixed", () => {
+      // Given
+      const msg: NotificationTextPrefixed = {
+        prefix: "warning",
+        text: "careful with this workspace",
+      }
+
+      // When
+      const isTextPrefixed = isNotificationTextPrefixed(msg)
+
+      // Then
+      expect(isTextPrefixed).toBe(true)
+    })
+    it("returns false if not prefixed", () => {
+      // Given
+      const msg = "plain ol' message"
+
+      // When
+      const isTextPrefixed = isNotificationTextPrefixed(msg)
+
       // Then
       expect(isTextPrefixed).toBe(false)
     })
diff --git a/site/src/components/GlobalSnackbar/utils.ts b/site/src/components/GlobalSnackbar/utils.ts
@@ -27,8 +27,10 @@ export const isNotificationText = (msg: AdditionalMessage): msg is string => {
 export const isNotificationTextPrefixed = (
   msg: AdditionalMessage | null,
 ): msg is NotificationTextPrefixed => {
-  // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
-  return typeof (msg as NotificationTextPrefixed)?.prefix !== "undefined"
+  if (msg) {
+    return typeof msg !== "string" && Object.prototype.hasOwnProperty.call(msg, "prefix")
+  }
+  return false
 }
 
 export const isNotificationList = (msg: AdditionalMessage): msg is string[] => {
