fix: fix appendAssign issues in test files

Claude · claude · Claude · commit e99fe03294ac · 2025-03-21T04:54:41.000Z
- Fix 'append result not assigned to the same slice' issues - Create new slices when appending in tests to avoid side effects 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
diff --git a/cli/server_test.go b/cli/server_test.go
@@ -1701,7 +1701,8 @@ func TestServer(t *testing.T) {
 			// Next, we instruct the same server to display the YAML config
 			// and then save it.
 			inv = inv.WithContext(testutil.Context(t, testutil.WaitMedium))
-			inv.Args = append(args, "--write-config")
+			newArgs := append([]string{}, args...)
+			inv.Args = append(newArgs, "--write-config")
 			fi, err := os.OpenFile(testutil.TempFile(t, "", "coder-config-test-*"), os.O_WRONLY|os.O_CREATE, 0o600)
 			require.NoError(t, err)
 			defer fi.Close()
diff --git a/cli/templatepush_test.go b/cli/templatepush_test.go
@@ -723,7 +723,7 @@ func TestTemplatePush(t *testing.T) {
 			template := coderdtest.CreateTemplate(t, client, owner.OrganizationID, templateVersion.ID)
 
 			// Test the cli command.
-			modifiedTemplateVariables := append(initialTemplateVariables,
+			modifiedTemplateVariables := append(append([]*proto.TemplateVariable{}, initialTemplateVariables...),
 				&proto.TemplateVariable{
 					Name:        "second_variable",
 					Description: "This is the second variable.",
@@ -792,7 +792,7 @@ func TestTemplatePush(t *testing.T) {
 			template := coderdtest.CreateTemplate(t, client, owner.OrganizationID, templateVersion.ID)
 
 			// Test the cli command.
-			modifiedTemplateVariables := append(initialTemplateVariables,
+			modifiedTemplateVariables := append(append([]*proto.TemplateVariable{}, initialTemplateVariables...),
 				&proto.TemplateVariable{
 					Name:        "second_variable",
 					Description: "This is the second variable.",
@@ -839,7 +839,7 @@ func TestTemplatePush(t *testing.T) {
 			template := coderdtest.CreateTemplate(t, client, owner.OrganizationID, templateVersion.ID)
 
 			// Test the cli command.
-			modifiedTemplateVariables := append(initialTemplateVariables,
+			modifiedTemplateVariables := append(append([]*proto.TemplateVariable{}, initialTemplateVariables...),
 				&proto.TemplateVariable{
 					Name:         "second_variable",
 					Description:  "This is the second variable",
@@ -905,7 +905,7 @@ func TestTemplatePush(t *testing.T) {
 			template := coderdtest.CreateTemplate(t, client, owner.OrganizationID, templateVersion.ID)
 
 			// Test the cli command.
-			modifiedTemplateVariables := append(initialTemplateVariables,
+			modifiedTemplateVariables := append(append([]*proto.TemplateVariable{}, initialTemplateVariables...),
 				&proto.TemplateVariable{
 					Name:        "second_variable",
 					Description: "This is the second variable.",
