fix!: enforce agent names be case-insensitive-unique per-workspace

ethanndickson · ethanndickson · commit ea0c97858c68 · 2025-02-19T05:26:25.000Z
diff --git a/provisioner/terraform/resources.go b/provisioner/terraform/resources.go
@@ -215,10 +215,12 @@ func ConvertState(ctx context.Context, modules []*tfjson.StateModule, rawGraph s
 				return nil, xerrors.Errorf("decode agent attributes: %w", err)
 			}
 
-			if _, ok := agentNames[tfResource.Name]; ok {
+			// Agent names must be case-insensitive-unique, to be unamibuiguous in
+			// `coder_app`s and CoderVPN DNS names.
+			if _, ok := agentNames[strings.ToLower(tfResource.Name)]; ok {
 				return nil, xerrors.Errorf("duplicate agent name: %s", tfResource.Name)
 			}
-			agentNames[tfResource.Name] = struct{}{}
+			agentNames[strings.ToLower(tfResource.Name)] = struct{}{}
 
 			// Handling for deprecated attributes. login_before_ready was replaced
 			// by startup_script_behavior, but we still need to support it for

Original file line number	Diff line number	Diff line change
`@@ -215,10 +215,12 @@ func ConvertState(ctx context.Context, modules []*tfjson.StateModule, rawGraph s`
`215`	`215`	`return nil, xerrors.Errorf("decode agent attributes: %w", err)`
`216`	`216`	`}`
`217`	`217`
`218`		`- if _, ok := agentNames[tfResource.Name]; ok {`
	`218`	`+ // Agent names must be case-insensitive-unique, to be unamibuiguous in`
	`219`	+ // `coder_app`s and CoderVPN DNS names.
	`220`	`+ if _, ok := agentNames[strings.ToLower(tfResource.Name)]; ok {`
`219`	`221`	`return nil, xerrors.Errorf("duplicate agent name: %s", tfResource.Name)`
`220`	`222`	`}`
`221`		`- agentNames[tfResource.Name] = struct{}{}`
	`223`	`+ agentNames[strings.ToLower(tfResource.Name)] = struct{}{}`
`222`	`224`
`223`	`225`	`// Handling for deprecated attributes. login_before_ready was replaced`
`224`	`226`	`// by startup_script_behavior, but we still need to support it for`