use port sharer

f0ssel · f0ssel · commit ea91c1b04d55 · 2024-01-30T19:34:35.000Z
diff --git a/coderd/portsharing/portsharing.go b/coderd/portsharing/portsharing.go
@@ -1,13 +1,19 @@
 package portsharing
 
+import (
+	"github.com/google/uuid"
+
+	"github.com/coder/coder/v2/codersdk"
+)
+
 type PortSharer interface {
-	CanRestrictShareLevel() bool
+	ShareLevelAllowed(workspaceID uuid.UUID, level codersdk.WorkspacePortSharingLevel) bool
 }
 
 type AGPLPortSharer struct{}
 
-func (AGPLPortSharer) CanRestrictShareLevel() bool {
-	return false
+func (AGPLPortSharer) ShareLevelAllowed(_ uuid.UUID, _ codersdk.WorkspacePortSharingLevel) bool {
+	return true
 }
 
 var DefaultPortSharer PortSharer = AGPLPortSharer{}
diff --git a/coderd/workspaceportsharing.go b/coderd/workspaceportsharing.go
@@ -23,11 +23,20 @@ import (
 func (api *API) postWorkspacePortShareLevel(rw http.ResponseWriter, r *http.Request) {
 	ctx := r.Context()
 	workspace := httpmw.WorkspaceParam(r)
+	portSharer := *api.PortSharer.Load()
 	var req codersdk.UpdateWorkspaceAgentPortSharingLevelRequest
 	if !httpapi.Read(ctx, rw, r, &req) {
 		return
 	}
 
+	shareLevelAllowed := portSharer.ShareLevelAllowed(workspace.ID, codersdk.WorkspacePortSharingLevel(req.ShareLevel))
+	if !shareLevelAllowed {
+		httpapi.Write(ctx, rw, http.StatusBadRequest, codersdk.Response{
+			Message: "Port sharing level not allowed.",
+		})
+		return
+	}
+
 	agents, err := api.Database.GetWorkspaceAgentsInLatestBuildByWorkspaceID(ctx, workspace.ID)
 	if err != nil {
 		httpapi.InternalServerError(rw, err)
@@ -59,7 +68,12 @@ func (api *API) postWorkspacePortShareLevel(rw http.ResponseWriter, r *http.Requ
 			return
 		}
 
-		if (req.ShareLevel == codersdk.Shar)
+		if req.ShareLevel == int(codersdk.WorkspaceAgentPortSharingLevelOwner) {
+			// If the port is not shared, and the user is trying to set it to owner,
+			// we don't need to do anything.
+			rw.WriteHeader(http.StatusOK)
+			return
+		}
 
 		err = api.Database.CreateWorkspacePortShareLevel(ctx, database.CreateWorkspacePortShareLevelParams{
 			WorkspaceID: workspace.ID,
diff --git a/enterprise/coderd/portsharing/portsharing.go b/enterprise/coderd/portsharing/portsharing.go
@@ -1,11 +1,17 @@
 package portsharing
 
+import (
+	"github.com/google/uuid"
+
+	"github.com/coder/coder/v2/codersdk"
+)
+
 type EnterprisePortSharer struct{}
 
 func NewEnterprisePortSharer() *EnterprisePortSharer {
 	return &EnterprisePortSharer{}
 }
 
-func (EnterprisePortSharer) CanRestrictShareLevel() bool {
-	return true
+func (EnterprisePortSharer) ShareLevelAllowed(_ uuid.UUID, _ codersdk.WorkspacePortSharingLevel) bool {
+	return false
 }
