fixup! chore(coderd/workspaceapps/apptest): fix test flake due to concurrent usage of same deployment

johnstcn · johnstcn · commit ea99e19a8db4 · 2024-03-21T13:03:47.000Z
diff --git a/coderd/workspaceapps/apptest/apptest.go b/coderd/workspaceapps/apptest/apptest.go
@@ -1766,9 +1766,10 @@ func assertWorkspaceLastUsedAtUpdated(t testing.TB, details *Details) {
 	require.NoError(t, err)
 	// Wait for stats to fully flush.
 	details.FlushStats()
-	after, err := details.SDKClient.Workspace(context.Background(), details.Workspace.ID)
-	require.NoError(t, err)
-	require.Greater(t, after.LastUsedAt, before.LastUsedAt, "workspace LastUsedAt not updated when it should have been")
+	require.Eventually(t, func() bool {
+		after, err := details.SDKClient.Workspace(context.Background(), details.Workspace.ID)
+		return assert.NoError(t, err) && after.LastUsedAt.After(before.LastUsedAt)
+	}, testutil.WaitShort, testutil.IntervalMedium)
 }
 
 // Except when it sometimes shouldn't (e.g. no access)
