fix agent loop

f0ssel · f0ssel · commit eb6f1aef0f7a · 2024-02-08T16:43:32.000Z
diff --git a/coderd/workspaceapps/request.go b/coderd/workspaceapps/request.go
@@ -322,14 +322,15 @@ func (r Request) getDatabase(ctx context.Context, db database.Store) (*databaseR
 		// Port sharing authorization
 		// First check if there is a port share for the port
 		agentName := agentNameOrID
-		id, err := uuid.Parse(agentNameOrID)
-		if err == nil {
-			// If parsing works it's an ID, let's get the name
-			agent, err := db.GetWorkspaceAgentByID(ctx, id)
-			if err != nil {
-				return nil, xerrors.Errorf("get workspace agent %q: %w", agentNameOrID, err)
+		id, _ := uuid.Parse(agentNameOrID)
+		for _, a := range agents {
+			if a.ID == id {
+				agentName = a.Name
+				break
+			}
+			if a.Name == agentNameOrID {
+				break
 			}
-			agentName = agent.Name
 		}
 
 		ps, err := db.GetWorkspaceAgentPortShare(ctx, database.GetWorkspaceAgentPortShareParams{
