Skip to content

Commit ec1bc1d

Browse files
johnstcnjohnstcn
committed
address PR comments
1 parent 1c7c901 commit ec1bc1d

File tree

10 files changed

+42
-108
lines changed

10 files changed

+42
-108
lines changed

‎coderd/apidoc/docs.go

Lines changed: 3 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎coderd/apidoc/swagger.json

Lines changed: 3 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎coderd/database/dump.sql

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎coderd/database/migrations/000173_provisioner_last_seen_at.up.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
ALTER TABLE provisioner_daemons
22
ADD COLUMN last_seen_at TIMESTAMP WITH TIME ZONE NULL,
3-
ADD COLUMN version TEXT NULL;
3+
ADD COLUMN version TEXT NOT NULL DEFAULT ''::TEXT;

‎coderd/database/models.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎codersdk/provisionerdaemons.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,9 @@ type ProvisionerDaemon struct {
4040
ID uuid.UUID `json:"id" format:"uuid"`
4141
CreatedAt time.Time `json:"created_at" format:"date-time"`
4242
UpdatedAt sql.NullTime `json:"updated_at" format:"date-time"`
43-
LastSeenAt sql.NullTime `json:"last_seen_at,omitempty" format:"date-time"`
43+
LastSeenAt NullTime `json:"last_seen_at,omitempty" format:"date-time"`
4444
Name string `json:"name"`
45-
Version sql.NullString `json:"version,omitempty"`
45+
Version string `json:"version,omitempty"`
4646
Provisioners []ProvisionerType `json:"provisioners"`
4747
Tags map[string]string `json:"tags"`
4848
}

‎docs/api/enterprise.md

Lines changed: 16 additions & 26 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎docs/api/schemas.md

Lines changed: 13 additions & 35 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎enterprise/coderd/provisionerdaemons.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -313,7 +313,7 @@ func convertProvisionerDaemon(daemon database.ProvisionerDaemon) codersdk.Provis
313313
ID: daemon.ID,
314314
CreatedAt: daemon.CreatedAt,
315315
UpdatedAt: daemon.UpdatedAt,
316-
LastSeenAt: daemon.LastSeenAt,
316+
LastSeenAt: codersdk.NullTime{NullTime: daemon.LastSeenAt},
317317
Name: daemon.Name,
318318
Tags: daemon.Tags,
319319
Version: daemon.Version,

‎site/src/api/typesGenerated.ts

Lines changed: 1 addition & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)