remove internet based request

Emyrk · Emyrk · commit eccc38fcfb2d · 2024-01-09T12:43:51.000-06:00
diff --git a/coderd/coderdtest/oidctest/idp.go b/coderd/coderdtest/oidctest/idp.go
@@ -223,6 +223,10 @@ func (f *FakeIDP) WellknownConfig() ProviderJSON {
 	return f.provider
 }
 
+func (f *FakeIDP) IssuerURL() *url.URL {
+	return f.issuerURL
+}
+
 func (f *FakeIDP) updateIssuerURL(t testing.TB, issuer string) {
 	t.Helper()
 
diff --git a/coderd/promoauth/oauth2_test.go b/coderd/promoauth/oauth2_test.go
@@ -47,7 +47,20 @@ func TestMaintainDefault(t *testing.T) {
 	// Verify the default client was not broken. This check is added because we
 	// extend the http.DefaultTransport. If a `.Clone()` is not done, this can be
 	// mis-used. It is cheap to run this quick check.
-	_, err = http.DefaultClient.Get("https://coder.com")
+	req, err := http.NewRequest(http.MethodGet,
+		must(idp.IssuerURL().Parse("/.well-known/openid-configuration")).String(), nil)
 	require.NoError(t, err)
+
+	resp, err := http.DefaultClient.Do(req)
+	require.NoError(t, err)
+	_ = resp.Body.Close()
+
 	require.Equal(t, count(), 2)
 }
+
+func must[V any](v V, err error) V {
+	if err != nil {
+		panic(err)
+	}
+	return v
+}

Original file line number	Diff line number	Diff line change
`@@ -223,6 +223,10 @@ func (f *FakeIDP) WellknownConfig() ProviderJSON {`
`223`	`223`	`return f.provider`
`224`	`224`	`}`
`225`	`225`
	`226`	`+func (f FakeIDP) IssuerURL() url.URL {`
	`227`	`+ return f.issuerURL`
	`228`	`+}`
	`229`	`+`
`226`	`230`	`func (f *FakeIDP) updateIssuerURL(t testing.TB, issuer string) {`
`227`	`231`	`t.Helper()`
`228`	`232`