fix start/end time tz returned in interval report

mafredri · mafredri · commit f190d80f255a · 2023-08-22T17:14:46.000Z
diff --git a/coderd/insights.go b/coderd/insights.go
@@ -276,8 +276,10 @@ func (api *API) insightsTemplates(rw http.ResponseWriter, r *http.Request) {
 	}
 	for _, row := range dailyUsage {
 		resp.IntervalReports = append(resp.IntervalReports, codersdk.TemplateInsightsIntervalReport{
-			StartTime:   row.StartTime,
-			EndTime:     row.EndTime,
+			// NOTE(mafredri): This might not be accurate over DST since the
+			// parsed location only contains the offset.
+			StartTime:   row.StartTime.In(startTime.Location()),
+			EndTime:     row.EndTime.In(startTime.Location()),
 			Interval:    interval,
 			TemplateIDs: row.TemplateIDs,
 			ActiveUsers: row.ActiveUsers,
diff --git a/coderd/testdata/insights/multiple_users_and_workspaces_week_other_timezone_(São_Paulo).json.golden b/coderd/testdata/insights/multiple_users_and_workspaces_week_other_timezone_(São_Paulo).json.golden
@@ -73,17 +73,17 @@
   },
   "interval_reports": [
     {
-      "start_time": "2023-08-15T03:00:00Z",
-      "end_time": "2023-08-16T03:00:00Z",
+      "start_time": "2023-08-15T00:00:00-03:00",
+      "end_time": "2023-08-16T00:00:00-03:00",
       "template_ids": [
         "00000000-0000-0000-0000-000000000001"
       ],
       "interval": "day",
       "active_users": 1
     },
     {
-      "start_time": "2023-08-16T03:00:00Z",
-      "end_time": "2023-08-17T03:00:00Z",
+      "start_time": "2023-08-16T00:00:00-03:00",
+      "end_time": "2023-08-17T00:00:00-03:00",
       "template_ids": [
         "00000000-0000-0000-0000-000000000001",
         "00000000-0000-0000-0000-000000000002"
@@ -92,40 +92,40 @@
       "active_users": 1
     },
     {
-      "start_time": "2023-08-17T03:00:00Z",
-      "end_time": "2023-08-18T03:00:00Z",
+      "start_time": "2023-08-17T00:00:00-03:00",
+      "end_time": "2023-08-18T00:00:00-03:00",
       "template_ids": [
         "00000000-0000-0000-0000-000000000002"
       ],
       "interval": "day",
       "active_users": 1
     },
     {
-      "start_time": "2023-08-18T03:00:00Z",
-      "end_time": "2023-08-19T03:00:00Z",
+      "start_time": "2023-08-18T00:00:00-03:00",
+      "end_time": "2023-08-19T00:00:00-03:00",
       "template_ids": [],
       "interval": "day",
       "active_users": 0
     },
     {
-      "start_time": "2023-08-19T03:00:00Z",
-      "end_time": "2023-08-20T03:00:00Z",
+      "start_time": "2023-08-19T00:00:00-03:00",
+      "end_time": "2023-08-20T00:00:00-03:00",
       "template_ids": [],
       "interval": "day",
       "active_users": 0
     },
     {
-      "start_time": "2023-08-20T03:00:00Z",
-      "end_time": "2023-08-21T03:00:00Z",
+      "start_time": "2023-08-20T00:00:00-03:00",
+      "end_time": "2023-08-21T00:00:00-03:00",
       "template_ids": [
         "00000000-0000-0000-0000-000000000001"
       ],
       "interval": "day",
       "active_users": 1
     },
     {
-      "start_time": "2023-08-21T03:00:00Z",
-      "end_time": "2023-08-22T03:00:00Z",
+      "start_time": "2023-08-21T00:00:00-03:00",
+      "end_time": "2023-08-22T00:00:00-03:00",
       "template_ids": [],
       "interval": "day",
       "active_users": 0
