fix(agent/agentssh): allow scp to exit with zero status (#12028)

mafredri · web-flow · commit f2aef0726b9d · 2024-02-07T10:22:31.000+02:00
Fixes #11786
diff --git a/agent/agentssh/agentssh.go b/agent/agentssh/agentssh.go
@@ -557,7 +557,7 @@ func (s *Server) sftpHandler(logger slog.Logger, session ssh.Session) {
 	defer server.Close()
 
 	err = server.Serve()
-	if errors.Is(err, io.EOF) {
+	if err == nil || errors.Is(err, io.EOF) {
 		// Unless we call `session.Exit(0)` here, the client won't
 		// receive `exit-status` because `(*sftp.Server).Close()`
 		// calls `Close()` on the underlying connection (session),
