chore: do not allow resetting password of non password users (#9003)

Emyrk · web-flow · commit f334b66178c4 · 2023-08-09T13:56:13.000-05:00
diff --git a/coderd/users.go b/coderd/users.go
@@ -733,6 +733,13 @@ func (api *API) putUserPassword(rw http.ResponseWriter, r *http.Request) {
 		return
 	}
 
+	if user.LoginType != database.LoginTypePassword {
+		httpapi.Write(ctx, rw, http.StatusBadRequest, codersdk.Response{
+			Message: "Users without password login type cannot change their password.",
+		})
+		return
+	}
+
 	err := userpassword.Validate(params.Password)
 	if err != nil {
 		httpapi.Write(ctx, rw, http.StatusBadRequest, codersdk.Response{
diff --git a/site/src/components/UsersTable/UsersTable.stories.tsx b/site/src/components/UsersTable/UsersTable.stories.tsx
@@ -42,6 +42,14 @@ Editable.args = {
       roles: [],
       status: "suspended",
     },
+    {
+      ...MockUser,
+      username: "OIDC User",
+      email: "oidc.user@coder.com",
+      roles: [],
+      status: "active",
+      login_type: "oidc",
+    },
   ],
   roles: MockAssignableSiteRoles,
   canEditUsers: true,
diff --git a/site/src/components/UsersTable/UsersTableBody.tsx b/site/src/components/UsersTable/UsersTableBody.tsx
@@ -205,7 +205,7 @@ export const UsersTableBody: FC<
                             {
                               label: t("resetPasswordMenuItem"),
                               onClick: onResetUserPassword,
-                              disabled: false,
+                              disabled: user.login_type !== "password",
                             },
                             {
                               label: t("listWorkspacesMenuItem"),

Original file line number	Diff line number	Diff line change
`@@ -205,7 +205,7 @@ export const UsersTableBody: FC<`
`205`	`205`	`{`
`206`	`206`	`label: t("resetPasswordMenuItem"),`
`207`	`207`	`onClick: onResetUserPassword,`
`208`		`- disabled: false,`
	`208`	`+ disabled: user.login_type !== "password",`
`209`	`209`	`},`
`210`	`210`	`{`
`211`	`211`	`label: t("listWorkspacesMenuItem"),`