Improve CreateTemplatePage

BrunoQuaresma · BrunoQuaresma · commit f3ebd3fb81e8 · 2023-03-09T22:57:14.000Z
diff --git a/site/package.json b/site/package.json
@@ -20,7 +20,7 @@
     "storybook": "start-storybook -p 6006",
     "storybook:build": "build-storybook",
     "test": "jest --selectProjects test",
-    "test:ci": "jest --selectProjects test --silent --verbose",
+    "test:ci": "jest --selectProjects test --silent",
     "test:coverage": "jest --selectProjects test --collectCoverage",
     "test:watch": "jest --selectProjects test --watch",
     "typegen": "xstate typegen 'src/**/*.ts'",
diff --git a/site/src/pages/CreateTemplatePage/CreateTemplatePage.test.tsx b/site/src/pages/CreateTemplatePage/CreateTemplatePage.test.tsx
@@ -12,7 +12,7 @@ import {
   renderWithAuth,
 } from "testHelpers/renderHelpers"
 import CreateTemplatePage from "./CreateTemplatePage"
-import { screen, waitFor } from "@testing-library/react"
+import { screen, waitFor, within } from "@testing-library/react"
 import userEvent from "@testing-library/user-event"
 import * as API from "api/api"
 
@@ -60,10 +60,11 @@ test("Create template with variables", async () => {
     ])
 
   // Render page, fill the name and submit
-  const { router } = await renderPage()
+  const { router, container } = await renderPage()
+  const form = container.querySelector("form") as HTMLFormElement
   await userEvent.type(screen.getByLabelText(/Name/), "my-template")
   await userEvent.click(
-    screen.getByRole("button", { name: /create template/i }),
+    within(form).getByRole("button", { name: /create template/i }),
   )
 
   // Wait for the variables form to be rendered and fill it
@@ -98,7 +99,7 @@ test("Create template with variables", async () => {
     .mockResolvedValue(MockTemplateVersion)
   jest.spyOn(API, "createTemplate").mockResolvedValue(MockTemplate)
   await userEvent.click(
-    screen.getByRole("button", { name: /create template/i }),
+    within(form).getByRole("button", { name: /create template/i }),
   )
 
   await waitFor(() => expect(API.createTemplate).toBeCalledTimes(1))
