Use NoLock variety to fix hung tests

dannykopping · dannykopping · commit f42af07c11ec · 2024-03-26T15:20:39.000+02:00
Signed-off-by: Danny Kopping &lt;danny@coder.com&gt;
diff --git a/coderd/database/dbmem/dbmem.go b/coderd/database/dbmem/dbmem.go
@@ -404,14 +404,14 @@ func (q *FakeQuerier) convertToWorkspaceRowsNoLock(ctx context.Context, workspac
 				}
 			}
 
-			if pj, err := q.GetProvisionerJobByID(ctx, build.JobID); err == nil {
+			if pj, err := q.getProvisionerJobByIDNoLock(ctx, build.JobID); err == nil {
 				wr.LatestBuildStatus = database.NullProvisionerJobStatus{ProvisionerJobStatus: pj.JobStatus, Valid: true}
 			}
 
 			wr.LatestBuildTransition = build.Transition
 		}
 
-		if u, err := q.GetUserByID(ctx, w.OwnerID); err == nil {
+		if u, err := q.getUserByIDNoLock(w.OwnerID); err == nil {
 			wr.Username = u.Username
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -404,14 +404,14 @@ func (q *FakeQuerier) convertToWorkspaceRowsNoLock(ctx context.Context, workspac`
`404`	`404`	`}`
`405`	`405`	`}`
`406`	`406`
`407`		`- if pj, err := q.GetProvisionerJobByID(ctx, build.JobID); err == nil {`
	`407`	`+ if pj, err := q.getProvisionerJobByIDNoLock(ctx, build.JobID); err == nil {`
`408`	`408`	`wr.LatestBuildStatus = database.NullProvisionerJobStatus{ProvisionerJobStatus: pj.JobStatus, Valid: true}`
`409`	`409`	`}`
`410`	`410`
`411`	`411`	`wr.LatestBuildTransition = build.Transition`
`412`	`412`	`}`
`413`	`413`
`414`		`- if u, err := q.GetUserByID(ctx, w.OwnerID); err == nil {`
	`414`	`+ if u, err := q.getUserByIDNoLock(w.OwnerID); err == nil {`
`415`	`415`	`wr.Username = u.Username`
`416`	`416`	`}`
`417`	`417`