Add comment to displayUsers

Emyrk · Emyrk · commit f57008c7b4ae · 2022-05-13T10:03:46.000-05:00
diff --git a/cli/userlist.go b/cli/userlist.go
@@ -25,7 +25,7 @@ func userList() *cobra.Command {
 				return err
 			}
 
-			_, err = fmt.Fprintln(cmd.OutOrStdout(), DisplayUsers(columns, users...))
+			_, err = fmt.Fprintln(cmd.OutOrStdout(), displayUsers(columns, users...))
 			return err
 		},
 	}
diff --git a/cli/users.go b/cli/users.go
@@ -22,10 +22,10 @@ func users() *cobra.Command {
 	return cmd
 }
 
-// DisplayUsers will return a table displaying all users passed in.
+// displayUsers will return a table displaying all users passed in.
 // filterColumns must be a subset of the user fields and will determine which
 // columns to display
-func DisplayUsers(filterColumns []string, users ...codersdk.User) string {
+func displayUsers(filterColumns []string, users ...codersdk.User) string {
 	tableWriter := cliui.Table()
 	header := table.Row{"ID", "Username", "Email", "Created At", "Status"}
 	tableWriter.AppendHeader(header)
diff --git a/cli/userstatus.go b/cli/userstatus.go
@@ -63,7 +63,7 @@ func setUserStatus(sdkStatus codersdk.UserStatus) *cobra.Command {
 			}
 
 			// Display the user
-			_, _ = fmt.Fprintln(cmd.OutOrStdout(), DisplayUsers(columns, user))
+			_, _ = fmt.Fprintln(cmd.OutOrStdout(), displayUsers(columns, user))
 
 			// User status is already set to this
 			if user.Status == sdkStatus {
diff --git a/cli/userstatus_test.go b/cli/userstatus_test.go
@@ -5,12 +5,11 @@ import (
 	"context"
 	"testing"
 
-	"github.com/coder/coder/codersdk"
-
 	"github.com/stretchr/testify/require"
 
 	"github.com/coder/coder/cli/clitest"
 	"github.com/coder/coder/coderd/coderdtest"
+	"github.com/coder/coder/codersdk"
 )
 
 func TestUserStatus(t *testing.T) {
diff --git a/codersdk/users.go b/codersdk/users.go
@@ -7,9 +7,8 @@ import (
 	"net/http"
 	"time"
 
-	"golang.org/x/xerrors"
-
 	"github.com/google/uuid"
+	"golang.org/x/xerrors"
 )
 
 // Me is used as a replacement for your own ID.

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ func userList() *cobra.Command {`
`25`	`25`	`return err`
`26`	`26`	`}`
`27`	`27`
`28`		`- _, err = fmt.Fprintln(cmd.OutOrStdout(), DisplayUsers(columns, users...))`
	`28`	`+ _, err = fmt.Fprintln(cmd.OutOrStdout(), displayUsers(columns, users...))`
`29`	`29`	`return err`
`30`	`30`	`},`
`31`	`31`	`}`
Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ func setUserStatus(sdkStatus codersdk.UserStatus) *cobra.Command {`
`63`	`63`	`}`
`64`	`64`
`65`	`65`	`// Display the user`
`66`		`- _, _ = fmt.Fprintln(cmd.OutOrStdout(), DisplayUsers(columns, user))`
	`66`	`+ _, _ = fmt.Fprintln(cmd.OutOrStdout(), displayUsers(columns, user))`
`67`	`67`
`68`	`68`	`// User status is already set to this`
`69`	`69`	`if user.Status == sdkStatus {`
Original file line number	Diff line number	Diff line change
`@@ -7,9 +7,8 @@ import (`
`7`	`7`	`"net/http"`
`8`	`8`	`"time"`
`9`	`9`
`10`		`- "golang.org/x/xerrors"`
`11`		`-`
`12`	`10`	`"github.com/google/uuid"`
	`11`	`+ "golang.org/x/xerrors"`
`13`	`12`	`)`
`14`	`13`
`15`	`14`	`// Me is used as a replacement for your own ID.`