time validation

greyscaled · greyscaled · commit f60f59b8360e · 2022-05-24T22:23:57.000Z
diff --git a/site/src/components/WorkspaceStats/WorkspaceScheduleForm.test.ts b/site/src/components/WorkspaceStats/WorkspaceScheduleForm.test.ts
@@ -32,7 +32,7 @@ describe("validationSchema", () => {
   })
 
   it("disallows ttl to be negative", () => {
-    const values = {
+    const values: WorkspaceScheduleFormValues = {
       ...valid,
       ttl: -1,
     }
@@ -41,7 +41,7 @@ describe("validationSchema", () => {
   })
 
   it("disallows all days-of-week to be false when startTime is set", () => {
-    const values = {
+    const values: WorkspaceScheduleFormValues = {
       ...valid,
       sunday: false,
       monday: false,
@@ -54,4 +54,40 @@ describe("validationSchema", () => {
     const validate = () => validationSchema.validateSync(values)
     expect(validate).toThrowError(Language.errorNoDayOfWeek)
   })
+
+  it("disallows startTime to be H:mm", () => {
+    const values: WorkspaceScheduleFormValues = {
+      ...valid,
+      startTime: "9:30",
+    }
+    const validate = () => validationSchema.validateSync(values)
+    expect(validate).toThrowError(Language.errorTime)
+  })
+
+  it("disallows startTime to be HH:m", () => {
+    const values: WorkspaceScheduleFormValues = {
+      ...valid,
+      startTime: "09:5",
+    }
+    const validate = () => validationSchema.validateSync(values)
+    expect(validate).toThrowError(Language.errorTime)
+  })
+
+  it("disallows an invalid startTime 13:01", () => {
+    const values: WorkspaceScheduleFormValues = {
+      ...valid,
+      startTime: "13:01",
+    }
+    const validate = () => validationSchema.validateSync(values)
+    expect(validate).toThrowError(Language.errorTime)
+  })
+
+  it("disallows an invalid startTime 09:60", () => {
+    const values: WorkspaceScheduleFormValues = {
+      ...valid,
+      startTime: "09:60",
+    }
+    const validate = () => validationSchema.validateSync(values)
+    expect(validate).toThrowError(Language.errorTime)
+  })
 })
diff --git a/site/src/components/WorkspaceStats/WorkspaceScheduleForm.tsx b/site/src/components/WorkspaceStats/WorkspaceScheduleForm.tsx
@@ -16,6 +16,7 @@ import { Stack } from "../Stack/Stack"
 
 export const Language = {
   errorNoDayOfWeek: "Must set at least one day of week",
+  errorTime: "Invalid time",
   daysOfWeekLabel: "Days of Week",
   daySundayLabel: "Sunday",
   dayMondayLabel: "Monday",
@@ -74,8 +75,20 @@ export const validationSchema = Yup.object({
   friday: Yup.boolean(),
   saturday: Yup.boolean(),
 
-  // TODO(Grey): Add validation that the string is "" or "HH:mm" (24 hours)
-  startTime: Yup.string(),
+  startTime: Yup.string()
+    .ensure()
+    .test("is-time-string", Language.errorTime, (value) => {
+      if (value === "") {
+        return true
+      } else if (!/^[0-9][0-9]:[0-9][0-9]$/.test(value)) {
+        return false
+      } else {
+        const parts = value.split(":")
+        const HH = Number(parts[0])
+        const mm = Number(parts[1])
+        return HH >= 0 && HH <= 12 && mm >= 0 && mm <= 59
+      }
+    }),
   ttl: Yup.number().min(0).integer(),
 })
 
