fix(enterprise/coderd/proxyhealth): properly defer healthCheckDuration observe (#10848)

johnstcn · ericpaulsen · commit f6d2346ff03b · 2023-11-27T01:40:24.000Z
diff --git a/enterprise/coderd/proxyhealth/proxyhealth.go b/enterprise/coderd/proxyhealth/proxyhealth.go
@@ -215,7 +215,7 @@ func (p *ProxyHealth) ProxyHosts() []string {
 // unreachable.
 func (p *ProxyHealth) runOnce(ctx context.Context, now time.Time) (map[uuid.UUID]ProxyStatus, error) {
 	// Record from the given time.
-	defer p.healthCheckDuration.Observe(time.Since(now).Seconds())
+	defer func() { p.healthCheckDuration.Observe(time.Since(now).Seconds()) }()
 
 	//nolint:gocritic // Proxy health is a system service.
 	proxies, err := p.db.GetWorkspaceProxies(dbauthz.AsSystemRestricted(ctx))
