best-effort fix but testing dbmem sort order is a waste of time

johnstcn · johnstcn · commit f735b6912167 · 2024-01-23T10:42:49.000Z
diff --git a/coderd/database/dbmem/dbmem.go b/coderd/database/dbmem/dbmem.go
@@ -7738,12 +7738,9 @@ func (q *FakeQuerier) GetAuthorizedWorkspaces(ctx context.Context, arg database.
 		w2 := workspaces[j]
 
 		// Order by: favorite first
-		if w1.FavoriteOf.Valid && !w2.FavoriteOf.Valid {
+		if w1.FavoriteOf == arg.OrderByFavorite {
 			return true
 		}
-		if !w1.FavoriteOf.Valid && w2.FavoriteOf.Valid {
-			return false
-		}
 
 		// Order by: running
 		w1IsRunning := isRunning(preloadedWorkspaceBuilds[w1.ID], preloadedProvisionerJobs[w1.ID])
diff --git a/coderd/workspaces_test.go b/coderd/workspaces_test.go
@@ -479,6 +479,10 @@ func TestAdminViewAllWorkspaces(t *testing.T) {
 func TestWorkspacesSortOrder(t *testing.T) {
 	t.Parallel()
 
+	if !dbtestutil.WillUsePostgres() {
+		t.Skip("sort order is only tested on postgres")
+	}
+
 	client, db := coderdtest.NewWithDatabase(t, nil)
 	firstUser := coderdtest.CreateFirstUser(t, client)
 	secondUserClient, secondUser := coderdtest.CreateAnotherUserMutators(t, client, firstUser.OrganizationID, []string{"owner"}, func(r *codersdk.CreateUserRequest) {
