steven said its ok to remove this

johnstcn · johnstcn · commit fa399d644ea7 · 2023-01-31T16:17:37.000Z
diff --git a/coderd/authzquery/workspace_test.go b/coderd/authzquery/workspace_test.go
@@ -3,20 +3,12 @@ package authzquery_test
 import (
 	"context"
 	"testing"
-	"time"
 
-	"github.com/moby/moby/pkg/namesgenerator"
-
-	"github.com/coder/coder/coderd/rbac"
-
-	"github.com/google/uuid"
 	"github.com/stretchr/testify/require"
 
-	"github.com/coder/coder/coderd/database"
-
 	"github.com/coder/coder/coderd/authzquery"
-	"github.com/coder/coder/coderd/coderdtest"
-	"github.com/coder/coder/coderd/database/databasefake"
+	"github.com/coder/coder/coderd/database"
+	"github.com/coder/coder/coderd/rbac"
 )
 
 func TestWorkspaceFunctions(t *testing.T) {
@@ -92,75 +84,7 @@ func TestWorkspaceFunctions(t *testing.T) {
 		tc := tc
 		t.Run(tc.Name, func(t *testing.T) {
 			t.Parallel()
-
 			testAuthorizeFunction(t, tc.Config)
 		})
 	}
-
-}
-
-func TestWorkspace(t *testing.T) {
-	// GetWorkspaceByID
-	var (
-		db = databasefake.New()
-		// TODO: Recorder should record all authz calls
-		rec   = &coderdtest.RecordingAuthorizer{}
-		q     = authzquery.NewAuthzQuerier(db, rec)
-		actor = rbac.Subject{
-			ID:     uuid.New().String(),
-			Roles:  rbac.RoleNames{rbac.RoleOwner()},
-			Groups: []string{},
-			Scope:  rbac.ScopeAll,
-		}
-		ctx = authzquery.WithAuthorizeContext(context.Background(), actor)
-	)
-
-	workspace := insertRandomWorkspace(t, db)
-
-	// Test recorder
-	_, err := q.GetWorkspaceByID(ctx, workspace.ID)
-	require.NoError(t, err)
-
-	_, err = q.UpdateWorkspace(ctx, database.UpdateWorkspaceParams{
-		ID:   workspace.ID,
-		Name: "new-name",
-	})
-	require.NoError(t, err)
-
-	rec.AssertActor(t, actor,
-		rec.Pair(rbac.ActionRead, workspace),
-		rec.Pair(rbac.ActionUpdate, workspace),
-	)
-	require.NoError(t, rec.AllAsserted())
-}
-
-func insertRandomWorkspace(t *testing.T, db database.Store, opts ...func(w *database.Workspace)) database.Workspace {
-	workspace := &database.Workspace{
-		ID:             uuid.New(),
-		CreatedAt:      time.Now().Add(time.Hour * -1),
-		UpdatedAt:      time.Now(),
-		OwnerID:        uuid.New(),
-		OrganizationID: uuid.New(),
-		TemplateID:     uuid.New(),
-		Deleted:        false,
-		Name:           namesgenerator.GetRandomName(1),
-		LastUsedAt:     time.Now(),
-	}
-	for _, opt := range opts {
-		opt(workspace)
-	}
-
-	newWorkspace, err := db.InsertWorkspace(context.Background(), database.InsertWorkspaceParams{
-		ID:                workspace.ID,
-		CreatedAt:         workspace.CreatedAt,
-		UpdatedAt:         workspace.UpdatedAt,
-		OwnerID:           workspace.OwnerID,
-		OrganizationID:    workspace.OrganizationID,
-		TemplateID:        workspace.TemplateID,
-		Name:              workspace.Name,
-		AutostartSchedule: workspace.AutostartSchedule,
-		Ttl:               workspace.Ttl,
-	})
-	require.NoError(t, err, "insert workspace")
-	return newWorkspace
 }
