Add better logging

kylecarbs · kylecarbs · commit fbb1bdb25e29 · 2022-11-13T18:13:51.000Z
diff --git a/agent/agent.go b/agent/agent.go
@@ -375,6 +375,7 @@ func (a *agent) runStartupScript(ctx context.Context, script string) error {
 		return nil
 	}
 
+	a.logger.Info(ctx, "running startup script", slog.F("script", script))
 	writer, err := os.OpenFile(filepath.Join(os.TempDir(), "coder-startup-script.log"), os.O_CREATE|os.O_RDWR, 0o600)
 	if err != nil {
 		return xerrors.Errorf("open startup script log file: %w", err)
diff --git a/agent/agent_test.go b/agent/agent_test.go
@@ -363,7 +363,7 @@ func TestAgent(t *testing.T) {
 		tempPath := filepath.Join(t.TempDir(), "content.txt")
 		content := "somethingnice"
 		setupAgent(t, codersdk.WorkspaceAgentMetadata{
-			StartupScript: fmt.Sprintf("echo %s > %s", content, tempPath),
+			StartupScript: fmt.Sprintf("echo %s> %s", content, tempPath),
 		}, 0)
 
 		var gotContent string

Original file line number	Diff line number	Diff line change
`@@ -375,6 +375,7 @@ func (a *agent) runStartupScript(ctx context.Context, script string) error {`
`375`	`375`	`return nil`
`376`	`376`	`}`
`377`	`377`
	`378`	`+ a.logger.Info(ctx, "running startup script", slog.F("script", script))`
`378`	`379`	`writer, err := os.OpenFile(filepath.Join(os.TempDir(), "coder-startup-script.log"), os.O_CREATE\|os.O_RDWR, 0o600)`
`379`	`380`	`if err != nil {`
`380`	`381`	`return xerrors.Errorf("open startup script log file: %w", err)`