Skip to content

Commit fc38b61

Browse files
authored
feat: use ConfirmDialog for ResetPasswordDialog (#2035)
* feat: use ConfirmDialog for ResetPasswordDialog * fix lint * make description typography a div * use paragraph for string description, div otherwise * fix lint
1 parent 60102cb commit fc38b61

File tree

2 files changed

+30
-25
lines changed

2 files changed

+30
-25
lines changed

site/src/components/ConfirmDialog/ConfirmDialog.tsx

+5-1
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,11 @@ export const ConfirmDialog: React.FC<ConfirmDialogProps> = ({
105105
</Typography>
106106

107107
{description && (
108-
<Typography className={styles.description} variant="body2">
108+
<Typography
109+
component={typeof description === "string" ? "p" : "div"}
110+
className={styles.description}
111+
variant="body2"
112+
>
109113
{description}
110114
</Typography>
111115
)}

site/src/components/ResetPasswordDialog/ResetPasswordDialog.tsx

+25-24
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
1-
import DialogActions from "@material-ui/core/DialogActions"
2-
import DialogContent from "@material-ui/core/DialogContent"
31
import DialogContentText from "@material-ui/core/DialogContentText"
42
import { makeStyles } from "@material-ui/core/styles"
53
import { FC } from "react"
64
import * as TypesGen from "../../api/typesGenerated"
7-
import { CodeBlock } from "../CodeBlock/CodeBlock"
8-
import { Dialog, DialogActionButtons, DialogTitle } from "../Dialog/Dialog"
5+
import { CodeExample } from "../CodeExample/CodeExample"
6+
import { ConfirmDialog } from "../ConfirmDialog/ConfirmDialog"
97

108
export interface ResetPasswordDialogProps {
119
open: boolean
@@ -36,32 +34,35 @@ export const ResetPasswordDialog: FC<ResetPasswordDialogProps> = ({
3634
}) => {
3735
const styles = useStyles()
3836

39-
return (
40-
<Dialog open={open} onClose={onClose}>
41-
<DialogTitle title={Language.title} />
42-
43-
<DialogContent>
44-
<DialogContentText variant="subtitle2">{Language.message(user?.username)}</DialogContentText>
45-
46-
<DialogContentText component="div">
47-
<CodeBlock lines={[newPassword ?? ""]} className={styles.codeBlock} />
48-
</DialogContentText>
49-
</DialogContent>
37+
const description = (
38+
<>
39+
<DialogContentText variant="subtitle2">{Language.message(user?.username)}</DialogContentText>
40+
<DialogContentText component="div" className={styles.codeBlock}>
41+
<CodeExample code={newPassword ?? ""} className={styles.codeExample} />
42+
</DialogContentText>
43+
</>
44+
)
5045

51-
<DialogActions>
52-
<DialogActionButtons
53-
onCancel={onClose}
54-
confirmText={Language.confirmText}
55-
onConfirm={onConfirm}
56-
confirmLoading={loading}
57-
/>
58-
</DialogActions>
59-
</Dialog>
46+
return (
47+
<ConfirmDialog
48+
type="info"
49+
hideCancel={false}
50+
open={open}
51+
onConfirm={onConfirm}
52+
onClose={onClose}
53+
title={Language.title}
54+
confirmLoading={loading}
55+
confirmText={Language.confirmText}
56+
description={description}
57+
/>
6058
)
6159
}
6260

6361
const useStyles = makeStyles(() => ({
6462
codeBlock: {
63+
marginBottom: 0,
64+
},
65+
codeExample: {
6566
minHeight: "auto",
6667
userSelect: "all",
6768
width: "100%",

0 commit comments

Comments
 (0)