another WIP

mtojek · mtojek · commit fc804bd4830d · 2024-09-10T15:25:17.000+02:00
diff --git a/coderd/notifications/reports/generator.go b/coderd/notifications/reports/generator.go
@@ -117,6 +117,9 @@ func reportFailedWorkspaceBuilds(ctx context.Context, logger slog.Logger, db dat
 			continue
 		}
 
+		// TODO Lazy-render the report.
+		reportData := map[string]any{}
+
 		templateAdmins, err := findTemplateAdmins(ctx, db, template)
 		if err != nil {
 			logger.Error(ctx, "unable to find template admins", slog.F("template_id", template.ID), slog.Error(err))
@@ -160,9 +163,6 @@ func reportFailedWorkspaceBuilds(ctx context.Context, logger slog.Logger, db dat
 				}
 			}
 
-			// TODO Lazy-render the report.
-			reportData := map[string]any{}
-
 			templateDisplayName := template.DisplayName
 			if templateDisplayName == "" {
 				templateDisplayName = template.Name
@@ -190,7 +190,6 @@ func reportFailedWorkspaceBuilds(ctx context.Context, logger slog.Logger, db dat
 				continue
 			}
 		}
-
 	}
 
 	err = db.DeleteOldReportGeneratorLogs(ctx, frequencyDays)
@@ -200,6 +199,13 @@ func reportFailedWorkspaceBuilds(ctx context.Context, logger slog.Logger, db dat
 	return nil
 }
 
+func buildDataForReportFailedWorkspaceBuilds() map[string]any {
+	// TODO Lazy-render the report.
+	reportData := map[string]any{}
+
+	return reportData
+}
+
 func findTemplateAdmins(ctx context.Context, db database.Store, template database.Template) ([]database.GetUsersRow, error) {
 	users, err := db.GetUsers(ctx, database.GetUsersParams{
 		RbacRole: []string{codersdk.RoleTemplateAdmin},

Original file line number	Diff line number	Diff line change
`@@ -117,6 +117,9 @@ func reportFailedWorkspaceBuilds(ctx context.Context, logger slog.Logger, db dat`
`117`	`117`	`continue`
`118`	`118`	`}`
`119`	`119`
	`120`	`+ // TODO Lazy-render the report.`
	`121`	`+ reportData := map[string]any{}`
	`122`	`+`
`120`	`123`	`templateAdmins, err := findTemplateAdmins(ctx, db, template)`
`121`	`124`	`if err != nil {`
`122`	`125`	`logger.Error(ctx, "unable to find template admins", slog.F("template_id", template.ID), slog.Error(err))`
`@@ -160,9 +163,6 @@ func reportFailedWorkspaceBuilds(ctx context.Context, logger slog.Logger, db dat`
`160`	`163`	`}`
`161`	`164`	`}`
`162`	`165`
`163`		`- // TODO Lazy-render the report.`
`164`		`- reportData := map[string]any{}`
`165`		`-`
`166`	`166`	`templateDisplayName := template.DisplayName`
`167`	`167`	`if templateDisplayName == "" {`
`168`	`168`	`templateDisplayName = template.Name`
`@@ -190,7 +190,6 @@ func reportFailedWorkspaceBuilds(ctx context.Context, logger slog.Logger, db dat`
`190`	`190`	`continue`
`191`	`191`	`}`
`192`	`192`	`}`
`193`		`-`
`194`	`193`	`}`
`195`	`194`
`196`	`195`	`err = db.DeleteOldReportGeneratorLogs(ctx, frequencyDays)`
`@@ -200,6 +199,13 @@ func reportFailedWorkspaceBuilds(ctx context.Context, logger slog.Logger, db dat`
`200`	`199`	`return nil`
`201`	`200`	`}`
`202`	`201`
	`202`	`+func buildDataForReportFailedWorkspaceBuilds() map[string]any {`
	`203`	`+ // TODO Lazy-render the report.`
	`204`	`+ reportData := map[string]any{}`
	`205`	`+`
	`206`	`+ return reportData`
	`207`	`+}`
	`208`	`+`
`203`	`209`	`func findTemplateAdmins(ctx context.Context, db database.Store, template database.Template) ([]database.GetUsersRow, error) {`
`204`	`210`	`users, err := db.GetUsers(ctx, database.GetUsersParams{`
`205`	`211`	`RbacRole: []string{codersdk.RoleTemplateAdmin},`