Skip to content

Error getting agent logs displaying upon workspace start/stops, despite no issue #10078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ericpaulsen opened this issue Oct 5, 2023 · 5 comments · Fixed by #10557
Closed
Assignees
Labels
s3 Bugs that confuse, annoy, or are purely cosmetic site Area: frontend dashboard

Comments

@ericpaulsen
Copy link
Member

since upgrading to 2.2.0, i've been seeing the below banner display during workspace stop/starts. i'm unable to consistently reproduce, and it is displaying even when there is no issue with the workspace agent init/startup script.

image

@ericpaulsen ericpaulsen added the site Area: frontend dashboard label Oct 5, 2023
@cdr-bot cdr-bot bot added the bug label Oct 5, 2023
@BrunoQuaresma
Copy link
Collaborator

I figured out this happens with Safari's old versions rather than 15.3

mdn/browser-compat-data#15592

@BrunoQuaresma
Copy link
Collaborator

Adding a polyfill should work:

if (!Array.prototype.at) {
  Array.prototype.at = function at(n) {
    let i = Math.trunc(n) || 0

    if (i < 0) i += this.length

    if (i < 0 || i >= this.length) return undefined

    return this[i]
  }
}

Took from https://github.com/vercel/next.js/pull/44436/files#diff-2f5596fa58e0c6b1fc2c6453e3a99ba4e25c585b657625c58f019b9e044e766cR133-R143

@matifali matifali added the s3 Bugs that confuse, annoy, or are purely cosmetic label Oct 6, 2023
@BrunoQuaresma
Copy link
Collaborator

@ericpaulsen this is related to old browser versions, so I would like to know from you how frequently we see customers using browser versions +2 years old.

@ericpaulsen
Copy link
Member Author

@BrunoQuaresma i don't have any data on our customer browser versions. although I am consistently seeing this behavior on Firefox 119 (latest).

@BrunoQuaresma
Copy link
Collaborator

BrunoQuaresma commented Nov 7, 2023

It was not related to the .at this time that I tried it 🤔. It is a known "bug" when dealing with incoming messages when the connection is closed socketio/socket.io#2016.

In our case, this happens because the "agent logs" can be toggled, and depending on whether that is open or not, it will close or open the connection. One way to reproduce this is to open the agent logs section and close it immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s3 Bugs that confuse, annoy, or are purely cosmetic site Area: frontend dashboard
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants