Skip to content

empty submit button for workspace parameters #10123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
matifali opened this issue Oct 8, 2023 · 0 comments · Fixed by #10286
Closed

empty submit button for workspace parameters #10123

matifali opened this issue Oct 8, 2023 · 0 comments · Fixed by #10286
Assignees
@BrunoQuaresma
Labels
s3 Bugs that confuse, annoy, or are purely cosmetic site Area: frontend dashboard

Comments

@matifali
Copy link
Member

matifali commented Oct 8, 2023

Problem

I have a template that is not coder_parameter, but on workspace settings --> Parameters, I get an empty button that allows submitting, too.
image

Suggested Solution

Hide the submit/cancel buttons if there is no coder_parameter.

cc: @BrunoQuaresma
@matifali matifali added site Area: frontend dashboard s3 Bugs that confuse, annoy, or are purely cosmetic bug labels Oct 8, 2023
@BrunoQuaresma BrunoQuaresma self-assigned this Oct 9, 2023
@BrunoQuaresma BrunoQuaresma mentioned this issue Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrunoQuaresma BrunoQuaresma

Labels
s3 Bugs that confuse, annoy, or are purely cosmetic site Area: frontend dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(site): display empty component when workspace has no parameters coder/coder
2 participants
@BrunoQuaresma @matifali