Skip to content

flake: TestWorkspaceDormant/OK reports too many audit logs #10396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
johnstcn opened this issue Oct 24, 2023 · 0 comments · Fixed by #10421
Closed

flake: TestWorkspaceDormant/OK reports too many audit logs #10396

johnstcn opened this issue Oct 24, 2023 · 0 comments · Fixed by #10421
Assignees
@johnstcn
Labels
s4 Internal bugs (e.g. test flakes), extreme edge cases, and bug risks

Comments

@johnstcn
Copy link
Member

johnstcn commented Oct 24, 2023 •
edited
Loading

Seen here: https://github.com/coder/coder/actions/runs/6631725530/job/18015861331

        	Error:      	"[{599ed8f4-7533-4793-86a9-22115ac0c546 2023-10-24 19:39:45.354896 +0000 UTC c2b46c45-4f07-49fa-b618-fa69f38b4148 7985859e-7f20-411b-9404-07513856a02e {{127.0.0.1 ffffffffffffffffffffffffffffffff} %!s(bool=true)} { %!s(bool=false)} workspace_build b750c889-1b93-4611-9bd1-8f258aca97a2  start {} %!s(int32=200) {"workspace_name":"fervent-morse6-Aef","build_number":"1","build_reason":"initiator","workspace_owner":""} 188c31b0-a218-47e4-9755-65b02c010358 } {0a214686-a5df-4609-b132-c8e6cf4a049f 2023-10-24 19:39:45.60328 +0000 UTC c2b46c45-4f07-49fa-b618-fa69f38b4148 00000000-0000-0000-0000-000000000000 {{127.0.0.1 ffffffffffffffffffffffffffffffff} %!s(bool=true)} {Go-http-client/1.1 %!s(bool=true)} workspace 55d359bf-0de6-485d-ad83-1513e2ead410 fervent-morse6-Aef write {} %!s(int32=200) {} 108fa788-2f40-4f39-ba8b-2e0cf13bb104 }]" should have 1 item(s), but has 2

		lastUsedAt := workspace.LastUsedAt
		auditRecorder.ResetLogs()
		err := client.UpdateWorkspaceDormancy(ctx, workspace.ID, codersdk.UpdateWorkspaceDormancy{
			Dormant: true,
		})
		require.NoError(t, err)
		require.Len(t, auditRecorder.AuditLogs(), 1) <-- here
@johnstcn johnstcn added the flake label Oct 24, 2023
@cdr-bot cdr-bot bot added the chore label Oct 24, 2023
@johnstcn johnstcn self-assigned this Oct 25, 2023
@johnstcn johnstcn changed the title flake: TestWorkspaceDormant/OK flake: TestWorkspaceDormant/OK reports too many audit logs Oct 27, 2023
@johnstcn johnstcn mentioned this issue Oct 30, 2023
Merged
@matifali matifali added bug s4 Internal bugs (e.g. test flakes), extreme edge cases, and bug risks and removed flake labels Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnstcn johnstcn

Labels
s4 Internal bugs (e.g. test flakes), extreme edge cases, and bug risks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(coderd): add MockAuditor.Contains test helper coder/coder
2 participants
@johnstcn @matifali