Skip to content

Unable to access "Build workspace" button when number of ephemeral resources requires "scrolling" #10577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mafredri opened this issue Nov 8, 2023 · 8 comments · Fixed by #10744
Assignees
Labels
s2 Broken use cases or features (with a workaround). Only humans may set this. site Area: frontend dashboard

Comments

@mafredri
Copy link
Member

mafredri commented Nov 8, 2023

I'm unable to access the button without resizing the browser window, scrolling does not work.

Browser: Safari

image

In fact, this dialogue disables scrolling on the entire page while it's open.

@cdr-bot cdr-bot bot added the bug label Nov 8, 2023
@matifali
Copy link
Member

matifali commented Nov 8, 2023

Good catch. May be we should move the button to top and also add scrolling to this view.
cc: @coder/ts

@matifali matifali added site Area: frontend dashboard s2 Broken use cases or features (with a workaround). Only humans may set this. labels Nov 8, 2023
@BrunoQuaresma
Copy link
Collaborator

I don't think moving the button to the top solves the issue, but the scrolling definitely does.

@BrunoQuaresma BrunoQuaresma self-assigned this Nov 8, 2023
@aslilac
Copy link
Member

aslilac commented Nov 8, 2023

we should just make this a dialog instead of a drop down imo

@BrunoQuaresma
Copy link
Collaborator

Why a dialog would be better?

@Parkreiner
Copy link
Member

I'm with Kayla. It feels to me that dropdowns are best when they're presenting a short list of links/buttons. But this dropdown can sometimes have so many parameters and config options that it turns into a form with 6+ inputs

I think my preference would be a dialog or rendering out content in the main part of the page

@BrunoQuaresma
Copy link
Collaborator

BrunoQuaresma commented Nov 8, 2023

I see, where would you add the button? I would try not adding a new one in the header because there is not too much space left there.

@aslilac
Copy link
Member

aslilac commented Nov 8, 2023

honestly I think the down arrow button would still be a fine way to summon it 🤷‍♀️ or maybe a … because I love those

@BrunoQuaresma
Copy link
Collaborator

I had an idea! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s2 Broken use cases or features (with a workaround). Only humans may set this. site Area: frontend dashboard
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants