Skip to content

flake: vscodessh logging #10663

Closed
Closed
@spikecurtis

Description

@spikecurtis

Race condition triggered

  cdr.dev/slog.Logger.log()
      /home/runner/go/pkg/mod/cdr.dev/slog@v1.6.2-0.20230929193652-f0c466fabe10/slog.go:212 +0x7c7
  cdr.dev/slog.Logger.Debug()
      /home/runner/go/pkg/mod/cdr.dev/slog@v1.6.2-0.20230929193652-f0c466fabe10/slog.go:85 +0x164
  github.com/coder/coder/v2/tailnet.Logger.func1()
      /home/runner/actions-runner/_work/coder/coder/tailnet/conn.go:1062 +0x86
  tailscale.com/wgengine.(*userspaceEngine).Ping()
      /home/runner/go/pkg/mod/github.com/coder/tailscale@v1.1.1-0.20231106123012-ba3acaa26275/wgengine/userspace.go:1251 +0x535
  tailscale.com/wgengine.(*watchdogEngine).Ping.func1()
      /home/runner/go/pkg/mod/github.com/coder/tailscale@v1.1.1-0.20231106123012-ba3acaa26275/wgengine/watchdog.go:162 +0xa3
  tailscale.com/wgengine.(*watchdogEngine).watchdog.func1()
      /home/runner/go/pkg/mod/github.com/coder/tailscale@v1.1.1-0.20231106123012-ba3acaa26275/wgengine/watchdog.go:117 +0x30
  tailscale.com/wgengine.(*watchdogEngine).watchdogErr.func2()
      /home/runner/go/pkg/mod/github.com/coder/tailscale@v1.1.1-0.20231106123012-ba3acaa26275/wgengine/watchdog.go:83 +0x39

Previous write at 0x00c0071a4030 by goroutine 14007:
  github.com/spf13/afero/mem.(*File).Close()
      /home/runner/go/pkg/mod/github.com/spf13/afero@v1.10.0/mem/file.go:131 +0x64
  github.com/coder/coder/v2/cli.(*RootCmd).vscodeSSH.func1.4()
      /home/runner/actions-runner/_work/coder/coder/cli/vscodessh.go:147 +0x48
  runtime.deferreturn()
      /opt/hostedtoolcache/go/1.20.11/x64/src/runtime/panic.go:476 +0x32
  github.com/coder/coder/v2/cli.(*RootCmd).Command.func6.1()
      /home/runner/actions-runner/_work/coder/coder/cli/root.go:283 +0x142
  github.com/coder/coder/v2/cli/clibase.RequireRangeArgs.func1.1()
      /home/runner/actions-runner/_work/coder/coder/cli/clibase/cmd.go:599 +0x511
  github.com/coder/coder/v2/cli/clibase.(*Invocation).run()
      /home/runner/actions-runner/_work/coder/coder/cli/clibase/cmd.go:413 +0x2137
  github.com/coder/coder/v2/cli/clibase.(*Invocation).run()
      /home/runner/actions-runner/_work/coder/coder/cli/clibase/cmd.go:350 +0x16fe
  github.com/coder/coder/v2/cli/clibase.(*Invocation).Run()
      /home/runner/actions-runner/_work/coder/coder/cli/clibase/cmd.go:503 +0x17d
  github.com/coder/coder/v2/cli/clitest.StartWithWaiter.func1()
      /home/runner/actions-runner/_work/coder/coder/cli/clitest/clitest.go:238 +0x114

Goroutine 15510 (running) created at:
  tailscale.com/wgengine.(*watchdogEngine).watchdogErr()
      /home/runner/go/pkg/mod/github.com/coder/tailscale@v1.1.1-0.20231106123012-ba3acaa26275/wgengine/watchdog.go:82 +0x371
  tailscale.com/wgengine.(*watchdogEngine).watchdog()
      /home/runner/go/pkg/mod/github.com/coder/tailscale@v1.1.1-0.20231106123012-ba3acaa26275/wgengine/watchdog.go:116 +0xaf
  tailscale.com/wgengine.(*watchdogEngine).Ping()
      /home/runner/go/pkg/mod/github.com/coder/tailscale@v1.1.1-0.20231106123012-ba3acaa26275/wgengine/watchdog.go:162 +0x1ae
  github.com/coder/coder/v2/tailnet.(*Conn).Ping.func2()
      /home/runner/actions-runner/_work/coder/coder/tailnet/conn.go:678 +0x9c

Goroutine 14007 (finished) created at:
  github.com/coder/coder/v2/cli/clitest.StartWithWaiter()
      /home/runner/actions-runner/_work/coder/coder/cli/clitest/clitest.go:235 +0x37a
  github.com/coder/coder/v2/cli_test.TestVSCodeSSH()
      /home/runner/actions-runner/_work/coder/coder/cli/vscodessh_test.go:52 +0x645
  testing.tRunner()
      /opt/hostedtoolcache/go/1.20.11/x64/src/testing/testing.go:1576 +0x216
  testing.(*T).Run.func1()
      /opt/hostedtoolcache/go/1.20.11/x64/src/testing/testing.go:1629 +0x47
==================

seen here: https://github.com/coder/coder/actions/runs/6849732730/job/18622522562

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions