Skip to content

flake: updateWorkspace.spec.ts e2e test #10989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Parkreiner opened this issue Dec 1, 2023 · 3 comments · Fixed by #11024
Closed

flake: updateWorkspace.spec.ts e2e test #10989

Parkreiner opened this issue Dec 1, 2023 · 3 comments · Fixed by #11024
Assignees
Labels
s4 Internal bugs (e.g. test flakes), extreme edge cases, and bug risks

Comments

@Parkreiner
Copy link
Member

Link to job
Footage

Error:

/home/runner/actions-runner/_work/coder/coder/site/e2e/helpers.ts:656:
   at helpers.ts:656

  654 |           "']",
  655 |       );
> 656 |       await parameterField.check();
      |                            ^
  657 |     } else if (richParameter.type === "list(string)") {
  658 |       throw new Error("not implemented yet"); // FIXME
  659 |     } else {
elementHandle.check: Element is not attached to the DOM

As far as I can tell, here's a basic summary of the issue:

  1. The offending test is "update workspace – new, optional, immutable parameter added" from updateWorkspace.spec
  2. We're getting an error from the call to the fillParameters helper function because the input field that is supposed to be getting filled out isn't being rendered to the DOM
  3. The helper is called when the test case calls the createWorkspace and updateWorkspace helpers, but from the footage, it looks like the error is from the update step?
@cdr-bot cdr-bot bot added the chore label Dec 1, 2023
@Parkreiner Parkreiner added flake s4 Internal bugs (e.g. test flakes), extreme edge cases, and bug risks labels Dec 1, 2023
@cdr-bot cdr-bot bot added the bug label Dec 1, 2023
@mtojek
Copy link
Member

mtojek commented Dec 1, 2023

Thanks for the report, Michael!

We're getting an error from the call to the fillParameters helper function because the input field that is supposed to be getting filled out isn't being rendered to the DOM

@BrunoQuaresma Has something changed in forms rendering? Is it possible that they get detached, and re-attached?

@BrunoQuaresma
Copy link
Collaborator

Not that I'm aware of 🤔

@Parkreiner
Copy link
Member Author

It's also possible that the correct UI wouldn't get rendered out because the backend data isn't reaching the "client"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s4 Internal bugs (e.g. test flakes), extreme edge cases, and bug risks
Projects
None yet
4 participants