Skip to content

Prompt users to authenticate external_auth on workspace update #11367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
matifali opened this issue Jan 2, 2024 — with Slack · 4 comments
Open

Prompt users to authenticate external_auth on workspace update #11367

matifali opened this issue Jan 2, 2024 — with Slack · 4 comments
Labels
s2 Broken use cases or features (with a workaround). Only humans may set this.

Comments

@matifali Slack
Copy link
Member

matifali commented Jan 2, 2024 •
edited
Loading

If a new external_auth is added to the template, there should be a way to prompt the user to authenticate.
Slack Message

Note

A new external authentication can be added directly as well as through a module to an existing template.

Workaround

Tip

Go to https://coder.example.com/settings/external-auth and authenticate/re-authenticate with the external provider manually.
@cdr-bot cdr-bot bot added the feature label Jan 2, 2024
@matifali matifali changed the title If a new external_auth is added to template there should be e way to prompt the user to authenticate If a new external_auth is added to template, prompt the user to authenticate Jan 2, 2024
@matifali matifali added feature s2 Broken use cases or features (with a workaround). Only humans may set this. and removed feature labels Jan 3, 2024
@matifali
Copy link
Member Author

matifali commented Jan 3, 2024

I am promoting it as a bug as it breaks one of the core workflows.
For auto starts when updates are mandatory, we should hold updating such workspaces and show a banner to the user in SSH sessions and UI about authenticating with the newly added external authentication when they connect to their workspaces.

@BrunoQuaresma BrunoQuaresma mentioned this issue Jan 3, 2024
Closed
@matifali matifali removed the feature label Jan 8, 2024
@matifali matifali mentioned this issue Jan 10, 2024
Closed
@matifali
Copy link
Member Author

This is also valid if the current token is expired.

@BrunoQuaresma BrunoQuaresma removed their assignment Jan 16, 2024
@matifali matifali mentioned this issue Jan 22, 2024
Open
@BrunoQuaresma
Copy link
Collaborator

This would require the BE to return this info somewhere, probably in the workspace or template payload. cc.: @mtojek

@mtojek
Copy link
Member

mtojek commented Feb 4, 2024

@BrunoQuaresma Which information do you mean exactly? Can you suggest a JSON snippet, so we can drill it down?

@matifali matifali changed the title If a new external_auth is added to template, prompt the user to authenticate If a new external_auth is added to template, prompt the user to authenticate on workspace update Mar 10, 2024
@matifali matifali mentioned this issue Mar 10, 2024
Closed
@kylecarbs kylecarbs changed the title If a new external_auth is added to template, prompt the user to authenticate on workspace update Prompt users to authenticate external_auth on workspace update May 31, 2024
@matifali matifali removed the bug label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
s2 Broken use cases or features (with a workaround). Only humans may set this.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@BrunoQuaresma @matifali @mtojek