Skip to content

Rate limit external auth requests #11843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Emyrk opened this issue Jan 26, 2024 · 4 comments
Open

Rate limit external auth requests #11843

Emyrk opened this issue Jan 26, 2024 · 4 comments
Labels
bug risk Prone to bugs

Comments

@Emyrk
Copy link
Member

Emyrk commented Jan 26, 2024

Related to #10853

External auth requests to coderd emit http requests to the external auth idps. A workspace does have the ability to cause coderd to make many ValidateToken requests. We should debounce or rate limit this to prevent a rogue workspace from eating away at the idp rate limits.

Basically rate limit per user usage of external auth to prevent deployment wide 429s.
@cdr-bot cdr-bot bot added the feature label Jan 26, 2024
@Emyrk Emyrk self-assigned this Feb 20, 2024
@Emyrk
Copy link
Member Author

Emyrk commented Feb 20, 2024

Related to #10853

@github-actions github-actions bot added the stale This issue is like stale bread. label Aug 19, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 27, 2024
@matifali
Copy link
Member

@Emyrk are you still interested in this?

@Emyrk
Copy link
Member Author

Emyrk commented Aug 27, 2024

@matifali Nah, let's close this

@Emyrk Emyrk mentioned this issue Oct 21, 2024
Open
@johnstcn
Copy link
Member

Re-opening based on comments in #14982

@johnstcn johnstcn reopened this Nov 20, 2024
@johnstcn johnstcn removed the stale This issue is like stale bread. label Nov 20, 2024
@coder-labeler coder-labeler bot added bug risk Prone to bugs needs decision Needs a higher-level decision to be unblocked. labels Nov 20, 2024
@johnstcn johnstcn removed the needs decision Needs a higher-level decision to be unblocked. label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug risk Prone to bugs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@johnstcn @Emyrk @matifali