Skip to content

Bug: Launching a workspace withmode=auto does not check for required external authentication for the template #12491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
michaelbrewer opened this issue Mar 9, 2024 · 1 comment · Fixed by #12538
Closed

Bug: Launching a workspace withmode=auto does not check for required external authentication for the template #12491

michaelbrewer opened this issue Mar 9, 2024 · 1 comment · Fixed by #12538
Assignees
@aslilac
Labels
s2 Broken use cases or features (with a workaround). Only humans may set this.

Comments

@michaelbrewer
Copy link
Contributor

michaelbrewer commented Mar 9, 2024 •
edited
Loading

When using "Open in Coder" and selecting mode=auto the developer should still be prompted to do external authentication if that requirement was not met.

You get the expected outcome when you use mode=form

Screenshot 2024-03-08 at 4 27 01 PM

Related Coder Docs: https://coder.com/docs/v2/latest/admin/external-auth#require-git-authentication-in-templates
Running 2.8.4 Coderd
@kylecarbs
Copy link
Member

Oof, good bug. Will fix!

@michaelbrewer michaelbrewer changed the title Bug: Bug: mode=auto does not check for required external authentication Mar 9, 2024
@michaelbrewer michaelbrewer changed the title Bug: mode=auto does not check for required external authentication Bug: mode=auto does not check for required external authentication Mar 9, 2024
@michaelbrewer michaelbrewer changed the title Bug: mode=auto does not check for required external authentication Bug: Launching a workspace withmode=auto does not check for required external authentication for the template Mar 9, 2024
@matifali matifali added s2 Broken use cases or features (with a workaround). Only humans may set this. bug labels Mar 10, 2024
@aslilac aslilac self-assigned this Mar 11, 2024
@aslilac aslilac mentioned this issue Mar 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aslilac aslilac

Labels
s2 Broken use cases or features (with a workaround). Only humans may set this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: disable auto-create if external auth requirements aren't met coder/coder
4 participants
@aslilac @michaelbrewer @kylecarbs @matifali