Skip to content

Test deprecate template flow #12505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sreya opened this issue Mar 10, 2024 · 2 comments · Fixed by #12685
Closed

Test deprecate template flow #12505

sreya opened this issue Mar 10, 2024 · 2 comments · Fixed by #12685
Assignees
@BrunoQuaresma
Labels
site Area: frontend dashboard
Milestone
Code Stability

Comments

@sreya
Copy link
Collaborator

sreya commented Mar 10, 2024

Part of this issue is determining whether an e2e test is necessary for listing templates. We do not support querying for this page so it may be suitable to simply have a unit test here.
@coder-labeler coder-labeler bot added the site Area: frontend dashboard label Mar 10, 2024
@sreya sreya added this to the FE Code Stability milestone Mar 10, 2024
@BrunoQuaresma BrunoQuaresma self-assigned this Mar 11, 2024
@mtojek
Copy link
Member

mtojek commented Mar 19, 2024

@BrunoQuaresma As the listing view does not provide any paging capabilities, you can create a view with:

  1. Regular template
  2. Regular template with an overridden display_name.
  3. Deprecate the template + check that the user can't click Create Workspace.

I'm good with resolving this issue if you can prove that these are covered with the frontend or storybook tests.

@BrunoQuaresma
Copy link
Collaborator

Hm... it is a good test case. Could I change this issue title to "Test deprecate template flow" instead of "e2e: List Templates"?

@BrunoQuaresma BrunoQuaresma changed the title e2e: List Templates e2e: Test deprecate template flow Mar 20, 2024
@BrunoQuaresma BrunoQuaresma changed the title e2e: Test deprecate template flow Test deprecate template flow Mar 20, 2024
@BrunoQuaresma BrunoQuaresma mentioned this issue Mar 20, 2024
Merged
BrunoQuaresma added a commit that referenced this issue Mar 21, 2024
@BrunoQuaresma
chore(site): add tests for deprecate template flow (#12685)
8499eac 
Closes #12505
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrunoQuaresma BrunoQuaresma

Labels
site Area: frontend dashboard
Projects
None yet
Milestone
Code Stability
Development

Successfully merging a pull request may close this issue.

chore(site): add tests for deprecate template flow coder/coder
3 participants
@BrunoQuaresma @sreya @mtojek