Skip to content

flake: data race in scaletest/reconnectingpty Test_Runner/ExpectTimeout/NoTimeout #12687

Closed
@johnstcn

Description

@johnstcn

Seen here: https://github.com/coder/coder/actions/runs/8359694931/job/22883576316

==================
WARNING: DATA RACE
Read at 0x00c01595a710 by goroutine 4398:
  os/exec.dedupEnvCase()
      /opt/hostedtoolcache/go/1.21.5/x64/src/os/exec/exec.go:1230 +0x17a
  os/exec.dedupEnv()
      /opt/hostedtoolcache/go/1.21.5/x64/src/os/exec/exec.go:1217 +0x1f9
  os/exec.(*Cmd).environ()
      /opt/hostedtoolcache/go/1.21.5/x64/src/os/exec/exec.go:1196 +0xad
  os/exec.(*Cmd).Start()
      /opt/hostedtoolcache/go/1.21.5/x64/src/os/exec/exec.go:688 +0x7d5
  os/exec.(*Cmd).Run()
      /opt/hostedtoolcache/go/1.21.5/x64/src/os/exec/exec.go:587 +0x26
  github.com/coder/coder/v2/agent/reconnectingpty.(*screenReconnectingPTY).sendCommand.func1()
      /home/runner/actions-runner/_work/coder/coder/agent/reconnectingpty/screen.go:344 +0x4ce
  github.com/coder/coder/v2/agent/reconnectingpty.(*screenReconnectingPTY).sendCommand()
      /home/runner/actions-runner/_work/coder/coder/agent/reconnectingpty/screen.go:366 +0x1f7
  github.com/coder/coder/v2/agent/reconnectingpty.(*screenReconnectingPTY).doAttach()
      /home/runner/actions-runner/_work/coder/coder/agent/reconnectingpty/screen.go:300 +0xf04
  github.com/coder/coder/v2/agent/reconnectingpty.(*screenReconnectingPTY).Attach()
      /home/runner/actions-runner/_work/coder/coder/agent/reconnectingpty/screen.go:172 +0x2f1
  github.com/coder/coder/v2/agent.(*agent).handleReconnectingPTY()
      /home/runner/actions-runner/_work/coder/coder/agent/agent.go:1467 +0x10c7
  github.com/coder/coder/v2/agent.(*agent).createTailnet.func5.2()
      /home/runner/actions-runner/_work/coder/coder/agent/agent.go:1220 +0x626

Previous write at 0x00c01595a710 by goroutine 4399:
  github.com/coder/coder/v2/agent/reconnectingpty.(*screenReconnectingPTY).sendCommand.func1()
      /home/runner/actions-runner/_work/coder/coder/agent/reconnectingpty/screen.go:341 +0x336
  github.com/coder/coder/v2/agent/reconnectingpty.(*screenReconnectingPTY).sendCommand()
      /home/runner/actions-runner/_work/coder/coder/agent/reconnectingpty/screen.go:366 +0x1f7
  github.com/coder/coder/v2/agent/reconnectingpty.(*screenReconnectingPTY).lifecycle()
      /home/runner/actions-runner/_work/coder/coder/agent/reconnectingpty/screen.go:149 +0x2e4
  github.com/coder/coder/v2/agent/reconnectingpty.newScreen.func1()
      /home/runner/actions-runner/_work/coder/coder/agent/reconnectingpty/screen.go:70 +0xcc

Goroutine 4398 (running) created at:
  github.com/coder/coder/v2/agent.(*agent).createTailnet.func5()
      /home/runner/actions-runner/_work/coder/coder/agent/agent.go:1199 +0x2e4
  github.com/coder/coder/v2/agent.(*agent).trackGoroutine.func1()
      /home/runner/actions-runner/_work/coder/coder/agent/agent.go:1126 +0x95

Goroutine 4399 (running) created at:
  github.com/coder/coder/v2/agent/reconnectingpty.newScreen()
      /home/runner/actions-runner/_work/coder/coder/agent/reconnectingpty/screen.go:70 +0x484
  github.com/coder/coder/v2/agent/reconnectingpty.New()
      /home/runner/actions-runner/_work/coder/coder/agent/reconnectingpty/reconnectingpty.go:79 +0x257
  github.com/coder/coder/v2/agent.(*agent).handleReconnectingPTY()
      /home/runner/actions-runner/_work/coder/coder/agent/agent.go:1451 +0xdc4
  github.com/coder/coder/v2/agent.(*agent).createTailnet.func5.2()
      /home/runner/actions-runner/_work/coder/coder/agent/agent.go:1220 +0x626
==================

Metadata

Metadata

Assignees

Labels

bug riskProne to bugss4Internal bugs (e.g. test flakes), extreme edge cases, and bug risks

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions