Skip to content

ssh into stopped workspace fails to start when there is an optional git external auth #13360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
michaelbrewer opened this issue May 24, 2024 · 3 comments · Fixed by #13368
Closed
Labels
cli Area: CLI

Comments

@michaelbrewer
Copy link
Contributor

michaelbrewer commented May 24, 2024

Steps to reproduce

Given a workspace template with some optional external git authentication

data "coder_external_auth" "gitlab-na" {
  id       = "gitlab-na"
  optional = true
}

data "coder_external_auth" "gitlab-emea" {
  id       = "gitlab-emea"
  optional = true
}

And one of the git external auth is not logged
And the workspace stopped

When logging into SSH the workspace should start up.

Outcome

SSH fails to start the workspace and can't CTL+C to exit

ssh coder.platform-onbarding.main
Workspace was stopped, starting workspace to allow connecting to "platform-onboarding"...
You must authenticate with Gitlab - EMEA to create a workspace with this template. Visit:

	https://coder.example.com/external-auth/gitlab-emea

⠎⠁ Waiting for Git authentication...

Expected outcome

The workspace should start up even if one of the optional git is not logged in

@coder-labeler coder-labeler bot added bug cli Area: CLI labels May 24, 2024
@kylecarbs
Copy link
Member

True

@michaelbrewer
Copy link
Contributor Author

Can have a look over the weekend as to why.

Does not happen when VScode connects to a stopped workspace.

@michaelbrewer
Copy link
Contributor Author

I haven't fixed the issue with CTL*C not exiting. But can try also.

Behind the scenes these messages will be lost for GUI apps like Fleet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Area: CLI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants