Skip to content

Trying to download logs for failed workspace makes entire page for that workspace unusable #13723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Parkreiner opened this issue Jun 28, 2024 · 4 comments
Closed

Trying to download logs for failed workspace makes entire page for that workspace unusable #13723

Parkreiner opened this issue Jun 28, 2024 · 4 comments
Assignees
@Parkreiner
Labels
s2 Broken use cases or features (with a workaround). Only humans may set this. site Area: frontend dashboard

Comments

@Parkreiner
Copy link
Member

Ran into this while testing out some of the RDP Coder module stuff

Problem

Trying to download the logs for a workspace that has failed throws an uncaught UI error. In addition, navigating away from the page and then trying to go back to the page still causes that error to persist. The page doesn't become usable again until you do a full page refresh from the browser.

Steps to reproduce

  1. Create a template that will run a script that is guaranteed to fail
  2. Create a new workspace from that template
  3. Navigate to that workspace's page
  4. Click the Additional Actions dropdown menu, and then "Download Logs"
  5. Once the uncaught error is thrown, press back on the browser
  6. Try to navigate back to the workspace page
  7. See the same uncaught UI error

Video

Screen.Recording.2024-06-28.at.2.03.37.PM.mov

Workarounds

  • As mentioned above, you can get around this by refreshing the page, but trying to download the logs again causes the issue to reappear.
@Parkreiner Parkreiner added site Area: frontend dashboard s2 Broken use cases or features (with a workaround). Only humans may set this. bug labels Jun 28, 2024
@Kira-Pilot
Copy link
Member

Seems as though this is only failing with RDP

@stirby
Copy link
Collaborator

stirby commented Jul 1, 2024

@Parkreiner just a reminder for your investigation: if this bug is reproducible on other templates please let me know so we can patch v2.13 after it goes out.

@Parkreiner
Copy link
Member Author

Parkreiner commented Jul 1, 2024 •
edited
Loading

Just got this into a reliably reproducible state. Next orders of business:

  1. Dig through the UI code to figure out what the state configuration is even like, and how we're reaching an invalid state
  2. Get a fix in place for this issue specifically

But to go a little beyond, I think it'd a be a good idea to beef up our error handling in the UI, because to be honest, we don't really have a lot. This is also the second time we've had a breaking UI bug slip through in the past two months.

Proposing an update to the UI that:

  1. Makes it so that errors like these don't blow up the entire UI, and at least parts of it will still be usable
  2. Gets rid of the default error styling
  3. Replaces the content that broke with a CTA that helps the user refresh the page and get things back on track faster

@Parkreiner Parkreiner mentioned this issue Jul 2, 2024
Merged
@Parkreiner
Copy link
Member Author

Closing this in favor of making a new issue for improving the app's error handling in general.

@Parkreiner Parkreiner mentioned this issue Jul 8, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Parkreiner Parkreiner

Labels
s2 Broken use cases or features (with a workaround). Only humans may set this. site Area: frontend dashboard
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Kira-Pilot @Parkreiner @stirby