-
Notifications
You must be signed in to change notification settings - Fork 875
Add password reset via email #14232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Proposal for how this would look:
The decision to send a one-time-passcode to the users email over sending a password reset link is that many places advise against clicking links in emails as it makes people more susceptible to phishing attacks. This flow doesn't pose the same risk as the user never has to click a link from their email. @stirby thoughts on this approach? |
This is exactly as I imagined, except:
But your rationale is very thoughtful. Let's do it. |
After a discussion with @johnstcn and @mafredri we have come up with a slightly simplified flow. Rather than these final 3 steps as originally presented:
We'd instead do this:
This removes an extra step from the flow. How does this sound to you @stirby? |
Yes, all for simplification @DanielleMaywood. One more question: do we hide the button when
|
For both it will be hidden.
|
Relates to #14232 This implements two endpoints (names subject to change): - `/api/v2/users/otp/request` - `/api/v2/users/otp/change-password`
@BrunoQuaresma Heads-up, this issue will require frontend work 👍 @DanielleMaywood will share details. |
To help with the UI, I created mockups based on the existing design and the described user flow. Note: the mockups are not pixel-perfect as they are partially based on screenshots Over to you @BrunoQuaresma 🏀 |
Thought: we should probably add a more aggressive rate-limit to the "request password reset" endpoint. I think once per minute should be more than sufficient. |
Closed by #15108 |
We allow administrators to reset a user's password via the CLI by connecting directly to the database (#1380). Otherwise, users may change their password in their account settings.
As a user, when I forget my password, I would like to reset it autonomously. This flow is facilitated in most products through a reset password link delivered to the user's email. We can implement the same flow using the new system-generated notifications.
When SMTP notifications are configured for a deployment, a new option would appear on the login page:
They'd then receive an email containing a link to create a new password.
Note
This would introduce a security vulnerability for teams, so admins should be able to disable the feature for their deployment or organization (once merged).
The text was updated successfully, but these errors were encountered: