Skip to content

Notifications: allow customers to rebrand email #14253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stirby opened this issue Aug 12, 2024 · 3 comments · Fixed by #14935
Closed

Notifications: allow customers to rebrand email #14253

stirby opened this issue Aug 12, 2024 · 3 comments · Fixed by #14935
Assignees
@defelmnq
Labels
customer-requested Features requested by enterprise customers. Only humans may set this. enterprise Enterprise-license / premium functionality
Milestone
Notifications: GA...

Comments

@stirby
Copy link
Collaborator

stirby commented Aug 12, 2024

Some customers use our deployment appearance options to rebrand the UI. If their users receive an email from Coder when the platform has been cosmetically changed, they may block the unfamiliar source.

We should pull from the deployment appearance and display it in the email like so:

Screenshot 2024-08-09 at 10 54 54 AM

Oddly, we suggest a logo with a 3:1 aspect ratio alongside the deployment name. Maybe we should only use the logo in the email, as some customers may include text in the image.

This doesn't block experimental but should be included in GA.
@stirby
Copy link
Collaborator Author

stirby commented Aug 12, 2024

cc @BrunoQuaresma

@coder-labeler coder-labeler bot added customer-requested Features requested by enterprise customers. Only humans may set this. enterprise Enterprise-license / premium functionality feature labels Aug 12, 2024
@BrunoQuaresma
Copy link
Collaborator

I think I can take this inside of the current sprint. Wdyt?

@stirby
Copy link
Collaborator Author

stirby commented Aug 13, 2024

That'd be great.

@stirby stirby mentioned this issue Oct 2, 2024
Merged
@defelmnq defelmnq self-assigned this Oct 3, 2024
@matifali matifali removed the feature label Oct 14, 2024
@matifali matifali added this to the Notifications: GA Release milestone Oct 17, 2024
defelmnq added a commit that referenced this issue Oct 23, 2024
@defelmnq
feat(coderd): add company logo when available for email notifications (…
c86d98a 
…#14935)

This PR aims to close #14253 

We keep the default behavior using the Coder logo if there's no logo
set.
Otherwise we want to use the logo based on the URL set in appearance.

---------

Co-authored-by: defelmnq <yvincent@coder.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@defelmnq defelmnq

Labels
customer-requested Features requested by enterprise customers. Only humans may set this. enterprise Enterprise-license / premium functionality
Projects
None yet
Milestone
Notifications: GA Release
Development

Successfully merging a pull request may close this issue.

feat(coderd): add company logo when available for email notifications coder/coder
4 participants
@BrunoQuaresma @matifali @defelmnq @stirby