Skip to content

No restart confirmation when changing workspace parameters #14319

@stirby

Description

@stirby

Problem

When changing workspace parameters in the UI (workspaces -> settings -> parameters), the submit button immediately triggers a workspace restart. This is annoying for customers as we don't display a warning against losing data when the workspace is running.

workspace_parameter_immediate_restart

Proposal

When restarting a workspace elsewhere in the UI, we have a large confirmation window to prevent work loss. We should add this as a second step when the user presses "submit" on the workspace parameters page when the workspace is running.

Screenshot 2024-08-15 at 2 09 22 PM

Stretch idea

We could give users the option to wait until the next restart with an adjusted dialogue. This will allow them one of two options:

  • Apply the parameter changes now
  • Apply the changes upon next restart

I am unsure if this is feasible as we'd have to store the new parameter values, and show that they're outdated in UI until the workspace restarts.

Screenshot 2024-08-15 at 4 17 37 PM

Metadata

Metadata

Assignees

No one assigned

    Labels

    customer-requestedFeatures requested by enterprise customers. Only humans may set this.design neededRequest for more beautyenterpriseEnterprise-license / premium functionalitysiteArea: frontend dashboard

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions