Skip to content

ui(provisioners): show tags for PSK provisioners #14441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
5 tasks
aslilac opened this issue Aug 26, 2024 · 2 comments · Fixed by #14628
Closed
5 tasks

ui(provisioners): show tags for PSK provisioners #14441

aslilac opened this issue Aug 26, 2024 · 2 comments · Fixed by #14628
Assignees
@aslilac
Labels
multi-org temporary label for multiple organizations related work site Area: frontend dashboard
Milestone
Organizations & C...

Comments

@aslilac
Copy link
Member

aslilac commented Aug 26, 2024 •
edited by Kira-Pilot
Loading

Built-in provisioners cannot have tags (other than scope:organization) and keyed provisioners are assigned their tags by the key. PSK provisioners are unique, in that they will be grouped by the UI, but each provisioner can have it's own independent tags. We should account for this in the UI.

Requirements

  • tooltip if provisioner has multiple tags
  • multiple tags should wrap inside tooltip
  • inline tag if provisioner only has one tag
  • only show multiple tags label if provisioners have distinct tags from one another (otherwise hide)
  • update storybooks
@coder-labeler coder-labeler bot added feature multi-org temporary label for multiple organizations related work site Area: frontend dashboard labels Aug 26, 2024
@aslilac
Copy link
Member Author

aslilac commented Aug 26, 2024 •
edited
Loading

Provisioners View – Built-in + PSK

This design uses either the org or user icon as the visual symbol of the tags, and some text describing the number of additional tags, which can be inspected by hovering over the indicator to bring up the additional tags.

https://www.figma.com/design/sruiQdZ5R73EBiaxqrVGxX/Provisioners?node-id=3010-286&t=0qcIIgUtLV1YesAR-1

@aslilac aslilac self-assigned this Aug 26, 2024
@Kira-Pilot
Copy link
Member

Est: S

@aslilac aslilac mentioned this issue Sep 10, 2024
Merged
@aslilac aslilac linked a pull request Sep 13, 2024 that will close this issue
feat: show tags for psk provisioners #14628
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aslilac aslilac

Labels
multi-org temporary label for multiple organizations related work site Area: frontend dashboard
Projects
None yet
Milestone
Organizations & Custom Roles (GA)
Development

Successfully merging a pull request may close this issue.

feat: show tags for psk provisioners coder/coder
4 participants
@aslilac @Kira-Pilot and others