Skip to content

Makefile "gen" target does not work with parallelization #14702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sreya opened this issue Sep 17, 2024 · 1 comment · Fixed by #14966
Closed

Makefile "gen" target does not work with parallelization #14702

sreya opened this issue Sep 17, 2024 · 1 comment · Fixed by #14966
Assignees
@Emyrk
Labels
s3 Bugs that confuse, annoy, or are purely cosmetic

Comments

@sreya
Copy link
Collaborator

sreya commented Sep 17, 2024

Works fine if you just do make gen but if I try to get some parallelization going it always falls over.

coder@dev coder (main) make -j -B gen
codersdk/rbacresources_gen.go:1:1: expected 'package', found 'EOF'
codersdk/rbacresources_gen.go:1:1: expected 'package', found 'EOF'
make: *** [Makefile:553: coderd/database/dump.sql] Error 1
make: *** Waiting for unfinished jobs....
make: *** [Makefile:617: examples/examples.gen.json] Error 1
make: *** Deleting file 'examples/examples.gen.json'
../../../../rbac/object_gen.go:1:1: expected 'package', found 'EOF'
+ pnpm install
Lockfile is up to date, resolution step is skipped
Already up to date
Done in 655ms
docs/admin/prometheus.md 114ms

cc @Emyrk you may know something about this
@sreya sreya added s3 Bugs that confuse, annoy, or are purely cosmetic bug labels Sep 17, 2024
@coder-labeler coder-labeler bot added the chore label Sep 17, 2024
@Emyrk
Copy link
Member

Emyrk commented Sep 17, 2024

Ooof, probably the gen requires the golang to compile, but a half-generated file is existing and is not valid Go. 😢

@Emyrk Emyrk self-assigned this Sep 17, 2024
@Emyrk Emyrk mentioned this issue Oct 3, 2024
Merged
@Emyrk Emyrk closed this as completed in 50d9206 Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Emyrk Emyrk

Labels
s3 Bugs that confuse, annoy, or are purely cosmetic
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: fix rbac_gen to allow parallel make gen coder/coder
2 participants
@sreya @Emyrk