Skip to content

handle invalid and nonexistent icon paths in coder_app #14759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
matifali opened this issue Sep 21, 2024 · 0 comments · Fixed by #16684
Closed

handle invalid and nonexistent icon paths in coder_app #14759

matifali opened this issue Sep 21, 2024 · 0 comments · Fixed by #16684
Assignees
@mtojek
Labels
customer-reported Bugs reported by enterprise customers. Only humans may set this.

Comments

@matifali
Copy link
Member

matifali commented Sep 21, 2024 •
edited
Loading

Problem

When we set a coder_app icon to a nonexistent path Coder dashboard is not able to render the icon and instead shows something like the image below.

image

This can happen when a coder module with a coder_app using a built in icon is used with an older Coder deployment not having that icon.

For example the cursror module icon is added to main but is not available in any Coder release yet.

Suggested solution

When the icon is set to a non existent icon let us skip rendering and it only show the display_text.
@matifali matifali added the customer-reported Bugs reported by enterprise customers. Only humans may set this. label Sep 21, 2024
@coder-labeler coder-labeler bot added the bug label Sep 21, 2024
@matifali matifali changed the title handle wrong or nonexistent icon paths in coder_app handle invalid and nonexistent icon paths in coder_app Sep 21, 2024
@matifali matifali removed the bug label Oct 14, 2024
@mtojek mtojek self-assigned this Feb 24, 2025
@mtojek mtojek mentioned this issue Feb 24, 2025
Merged
@mtojek mtojek closed this as completed in a2d4b99 Feb 25, 2025
aslilac pushed a commit that referenced this issue Feb 27, 2025
@mtojek @aslilac
fix: hide app icon if not found (#16684)
4aa9685 
Fixes: #14759
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mtojek mtojek

Labels
customer-reported Bugs reported by enterprise customers. Only humans may set this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: hide app icon if not found coder/coder
2 participants
@matifali @mtojek